Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/path.dirname #41

Merged
merged 2 commits into from
Oct 27, 2016
Merged

Fix/path.dirname #41

merged 2 commits into from
Oct 27, 2016

Conversation

hotoo
Copy link
Owner

@hotoo hotoo commented Oct 27, 2016

@hotoo
code(style): eslint
6d4d0cb
@hotoo
fix(path.dirname): path.dirname(undefined) throw error since node v6
42c1a45 
path.dirname()
TypeError: Path must be a string. Received undefined.

fixed #40
@hotoo hotoo merged commit 7c7e4f7 into master Oct 27, 2016
@hotoo hotoo deleted the fix/path.dirname branch October 27, 2016 02:44
hotoo added a commit that referenced this pull request Mar 3, 2017
@hotoo
Merge pull request #41 from hotoo/fix/path.dirname
e2eec4f 
Fix/path.dirname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaks with node v6
1 participant
@hotoo