-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwind configuration #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely stuff. Can we agree on a direction on consistent HTML quote usage please and then proceed?
The lint step of the CI job is failing. If you can see a quick fix, then we should fix. If it is more tricky, feel with should take an issue and proceed, a little later. |
Agreed that the HTML autoformatting would be nice. Unfortunately prettier breaks django template language syntax, will have a quick google for an alternative but otherwise will park that request in the backlog. |
Cool, now we have a pretty good Django HTML linter and code formatter! It will auto-reindent HTML which is nice, and will alert us to bad HTML practice like mixed quotes and unclosed tags and things like that — we'll have to fix them but they're pretty easy to fix. This has been added to:
Example linting error:
|
Oh god, not this |
Wehey! @conatus I managed to solve all sorts of CI issues alongside Django HTML formatting and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Feels like a stronger version of the CI setup which will ensure a higher code quality immediately, so worthwhile in the round.
This PR adds the foundational design tokens from the Figma, based on Flowbite.
Motivation and Context
Context here is that, because we're using Flowbite as the underlying design system, it should be easy to check Figma for the correct classnames to apply to precisely produce the desired styling in HTML and CSS.
There are three CSS files that we should add stuff to, if required:
frontend/scss/base.scss
: this is for basic overriding styles that apply globally. Be very careful about this. Most always you'll want to define components or utilities and apply these in a scoped context in HTML.frontend/scss/components.scss
: this is for composing utilities together into semantically named classes. For example, I can imagine us pretty soon implementing standarddiv.label
anda.link
component classes for use around the site in different places, although not alldiv
anda
elements want to be automatically styled that way.frontend/scss/utilities.scss
: this is the place to add more tailwind-style class utilities here, named according to their visual effect (e.g.text-blue
)How Can It Be Tested?
As you build out UI, if you find that these classes aren't producing the expected visual output compared to Figma, we need to update the Tailwind file.
How Will This Be Deployed?
N/A
Types of changes
Checklist: