Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature search is not consistent #360

Closed
dt2patel opened this issue Jul 13, 2024 · 1 comment
Closed

Feature search is not consistent #360

dt2patel opened this issue Jul 13, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v3.1.0

Comments

@dt2patel
Copy link
Contributor

Current behavior

Feature search and sometimes take search doesn't feel consistent. We need to add a spinner to show search is happening as well as also show a default list of features so that user feels like there is at least some content.

https://jam.dev/c/6aed993e-a5a9-4e11-b1d4-bb14c8063e47

Tried searching for black clothes but no keyword was working
@dt2patel dt2patel added the bug Something isn't working label Jul 13, 2024
@ravilodhi ravilodhi moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jul 15, 2024
@amansinghbais amansinghbais self-assigned this Jul 29, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jul 30, 2024
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 30, 2024
@amansinghbais
Improved: product filters fetching, searching and infinite scrolling …
3b8f038 
…logic (hotwax#360)
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 30, 2024
@amansinghbais
Fixed: scrolling issue in the product filters modal (hotwax#360)
6bffb0c
@amansinghbais amansinghbais mentioned this issue Jul 30, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 30, 2024
@amansinghbais
Improved: added check for displaying loaded content in ionInfiniteScr…
ff10edb 
…oll and optimized code (hotwax#360)
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jul 30, 2024
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 30, 2024
@amansinghbais
Improved: clearing facetOptions state while clearing util state (hotw…
44c0a03 
…ax#360)
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 31, 2024
@amansinghbais
Improved: persisting and using the facetOptions from state if already…
15be2b1 
… exists (hotwax#360)
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 31, 2024
@amansinghbais
Improved: logic for client side searching (hotwax#360)
ae59685
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 31, 2024
@amansinghbais
Fixed: scrolling error on enableScrolling (hotwax#360)
1023f3b
@ravilodhi ravilodhi removed their assignment Aug 5, 2024
@amansinghbais amansinghbais mentioned this issue Aug 6, 2024
Closed
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Aug 8, 2024
@amansinghbais
Improved: payload used for fetching product filters (hotwax#360)
e227ae6
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Aug 8, 2024
@amansinghbais
Improved: breakpoint for disabling scrolling (hotwax#360)
56af957
ravilodhi added a commit that referenced this issue Aug 8, 2024
@ravilodhi
Merge pull request #366 from amansinghbais/#360
4b81984 
Improved: product filters fetching logic, and added support for client side searching and infinite scrolling (#360)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Aug 8, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Aug 13, 2024
@Adameddy26
Copy link

Issue verified and working fine in release v3.1.0. Hence, closing this ticket.
https://jam.dev/c/82a275a6-d38d-4c3d-a467-c47a0533f0d7

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Aug 13, 2024
ravilodhi added a commit that referenced this issue Dec 13, 2024
@ravilodhi
Improved: Updated RuleGroup.lastModifiedDate whenever rules are added…
fbf0519 
…, modified or archived (#360).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v3.1.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravilodhi @dt2patel @amansinghbais @Adameddy26