Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implemented: UI for showing notifications #275

Closed
wants to merge 7 commits into from
Closed

[WIP] Implemented: UI for showing notifications #275

wants to merge 7 commits into from

Conversation

alsoK2maan
Copy link
Contributor

Related Issues

Closes #274

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@alsoK2maan alsoK2maan changed the title Implemented: UI for showing notifications [WIP] Implemented: UI for showing notifications Sep 13, 2023
@alsoK2maan
Copy link
Contributor Author

Currently, having issues with

  • showing the icon in the background notifications popup.
  • the on click link. The generated link is not consistent (at times it is default, at times it is app-specific)
  • Pinia reactivity, hence, unable to update the notification icon colour without refreshing the page.

@alsoK2maan
Copy link
Contributor Author

Closing, will be done through #279.

@alsoK2maan alsoK2maan closed this Sep 22, 2023
@alsoK2maan alsoK2maan deleted the bopis/notifications branch September 22, 2023 09:04
R-Sourabh added a commit to R-Sourabh/bopis that referenced this pull request Mar 18, 2024
R-Sourabh added a commit to R-Sourabh/bopis that referenced this pull request Mar 27, 2024
R-Sourabh added a commit to R-Sourabh/bopis that referenced this pull request Apr 24, 2024
R-Sourabh added a commit to R-Sourabh/bopis that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOPIS (Buy Online, Pick Up In-Store)
2 participants