Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made some minor improvements in the UI (#1ye5r94) #40

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Made some minor improvements in the UI (#1ye5r94) #40

merged 3 commits into from
Jan 12, 2022

Conversation

ymaheshwari1
Copy link
Contributor

Related Issues

Closes #

Short Description and Why It's Useful

  • Added prefix Shopify order on the order id.
  • Removed extra space after the attributes names(Color and Size)
  • Registered ion-note component as it was throwing a warning and improved indentation

Screenshots of Visual Changes before/after (If There Are Any)

Before:
image

After:
image

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

dt2patel
dt2patel approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dt2patel dt2patel merged commit 40982d9 into hotwax:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt2patel dt2patel dt2patel approved these changes

@adityasharma7 adityasharma7 Awaiting requested review from adityasharma7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymaheshwari1 @dt2patel