Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous gitbook search query persists on reopening Gitbook Search Modal #313

Closed
2 tasks
amansinghbais opened this issue Jul 15, 2024 · 1 comment
Closed
2 tasks

Previous gitbook search query persists on reopening Gitbook Search Modal #313

amansinghbais opened this issue Jul 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@amansinghbais
Copy link
Contributor

Current behavior

Currently when we close the gitbook search modal after querying something and reopen it the previous query and response still shows up.

Expected behavior

Whenever we open the Gitbook search modal it should appear as a clear console without any history.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@amansinghbais amansinghbais added the bug Something isn't working label Jul 15, 2024
@amansinghbais amansinghbais self-assigned this Jul 15, 2024
amansinghbais added a commit to amansinghbais/dxp-components that referenced this issue Jul 15, 2024
@amansinghbais
Improved: clearing gitbook search modal queries on modal dismiss and …
a9a3087 
…promise for fetching resources (hotwax#313)
@amansinghbais amansinghbais mentioned this issue Jul 15, 2024
Merged
3 tasks
@amansinghbais amansinghbais moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Jul 15, 2024
This was referenced Jul 15, 2024
Closed
Closed
ymaheshwari1 added a commit that referenced this issue Jul 18, 2024
@ymaheshwari1
Merge pull request #314 from amansinghbais/#313
23d3b96 
Improved: clearing gitbook search modal queries on modal dismiss and promise for fetching resources (#313)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 18, 2024
@dt2patel
Copy link
Contributor

Tested, looks good

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dt2patel @amansinghbais