Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Separator Horizontal Line Between Product Stores and Facilities in Groups Tab #291

Closed
Adameddy26 opened this issue Jul 29, 2024 · 5 comments
Assignees

Comments

@Adameddy26
Copy link

Adameddy26 commented Jul 29, 2024

Note

Also there is extra separator horizontal line present at the bottom of few parking cards.

Current behavior

The separator horizontal line is missing, leading to a lack of visual separation between the "Product Stores" and "Facilities" sections.

Expected behavior

A clear separator horizontal line should be visible between the "Product Stores" and "Facilities" sections, providing a visual distinction between these sections.

Steps to reproduce the issue

Open the Facilities app.
Navigate to the "Groups" tab.
Observe the area between the "Product Stores" and "Facilities" sections.

Environment details

App version : V1.8.2
App environment : UAT

Additional information

Screenshot from 2024-07-29 16-30-55

@Adameddy26 Adameddy26 added the bug Something isn't working label Jul 29, 2024
@Adameddy26 Adameddy26 changed the title Missing Separator Horizontal Line Between Product Stores and Facilities in Groups Tab of Facilities App Missing Separator Horizontal Line Between Product Stores and Facilities in Groups Tab Jul 29, 2024
@ymaheshwari1
Copy link
Contributor

@Ridwan6947

@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jul 29, 2024
Ridwan6947 added a commit to Ridwan6947/facilities that referenced this issue Jul 30, 2024
Ridwan6947 added a commit to Ridwan6947/facilities that referenced this issue Jul 30, 2024
Ridwan6947 added a commit to Ridwan6947/facilities that referenced this issue Jul 30, 2024
ymaheshwari1 added a commit that referenced this issue Jul 30, 2024
Fixed: Added a horizontal line between product store and facility and removed line from the last (#291)
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to ⏸️ Dev complete in Digital Experience Platform Jul 30, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 📅 Planned in Digital Experience Platform Aug 20, 2024
@Adameddy26
Copy link
Author

Verified in release v1.9.0 and found that extra separator horizontal line is still present in the bottom of parking cards. Hence, reopening it.
Screenshot from 2024-08-20 16-01-12

@github-project-automation github-project-automation bot moved this from 📅 Planned to ✅ Done in Digital Experience Platform Aug 20, 2024
@Adameddy26 Adameddy26 reopened this Aug 20, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📅 Planned in Digital Experience Platform Aug 20, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Aug 20, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Aug 20, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Aug 20, 2024
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Aug 20, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Aug 27, 2024
ravilodhi added a commit that referenced this issue Aug 27, 2024
Improved: code for adding consistency in the item bottom lines in parking cards (#291)
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Aug 27, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Aug 27, 2024
@Adameddy26
Copy link
Author

Adameddy26 commented Aug 28, 2024

Issue verified in release v1.9.2 and found that extra space is visible at the bottom of parking cards. Hence, reopening this issue.
@dt2patel This seems to be inconsistent if we compare the cards UI of parking and groups. In parking, we maintain the height of cards in a row but not in the groups. Please share your thoughts on what should be done.

Parking UI -
Screenshot from 2024-08-28 12-09-49

Groups UI -
Screenshot from 2024-08-28 12-30-22

@Adameddy26 Adameddy26 moved this from 🛠 In QA to 📅 Planned in Digital Experience Platform Aug 28, 2024
@Adameddy26 Adameddy26 assigned dt2patel and unassigned amansinghbais Aug 28, 2024
@dt2patel
Copy link
Contributor

Correct @Adameddy26 card height should be restricted to the content of the cards. The styling used in the groups page should be mirrored in the parkings page.

@dt2patel dt2patel assigned ravilodhi and unassigned dt2patel Aug 29, 2024
@ravilodhi ravilodhi assigned amansinghbais and unassigned ravilodhi Sep 3, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 👀 In review in Digital Experience Platform Sep 3, 2024
ymaheshwari1 added a commit that referenced this issue Sep 17, 2024
Improved: restricted the card height to the content in parkings page (#291)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Sep 17, 2024
@Adameddy26 Adameddy26 self-assigned this Sep 20, 2024
@Adameddy26
Copy link
Author

Verified and working fine in release v1.9.3. Hence, closing this ticket.

image

@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Sep 20, 2024
@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants