Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Issues Identified in the Facilities App #337

Closed
2 tasks
ravilodhi opened this issue Dec 3, 2024 · 3 comments
Closed
2 tasks

Misc Issues Identified in the Facilities App #337

ravilodhi opened this issue Dec 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working release-v1.10.0

Comments

@ravilodhi
Copy link
Contributor

Current behavior

The following issues were encountered while creating a facility in the Facility App. These need to be addressed to ensure accurate and complete facility information:

Issues:
Missing Contact Email Address Field
Description: There is no option to add a contact email address while adding contact details for a facility.
Impact: Email is a critical communication medium, and its absence limits the ability to record complete contact details for the facility.

Incorrect Formatting of Contact Number on OMS Facility Details Page
Description: When a contact number is added via the Facility App, it appears incorrectly formatted on the OMS Facility Details page. For example,
+1-3058301957 is displayed as ++1-3058301957.
Impact: Misformatted contact numbers can cause confusion and lead to failed communication attempts.

Owner ID Missing in the App
Description: While creating a facility via CSV, the Owner-party-ID can be added. However, there is no option to add the Owner-party-ID directly from the app interface.
Impact: This inconsistency between CSV uploads and app-based creation hampers the ability to maintain uniformity and completeness in facility data.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

@ravilodhi ravilodhi added the bug Something isn't working label Dec 3, 2024
@ravilodhi ravilodhi moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Dec 3, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Dec 4, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Dec 5, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Dec 5, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Dec 5, 2024
@R-Sourabh R-Sourabh moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Dec 6, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Dec 10, 2024
…y to use a single action for retrieving address info, contact info, and email address (hotwax#337)
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Dec 10, 2024
@R-Sourabh
Copy link
Contributor

For Owner ID Missing in the App :
As I checked, the ownerPartyId is being passed by default from the app side when creating a facility.

R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Dec 18, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Dec 18, 2024
ymaheshwari1 added a commit that referenced this issue Dec 19, 2024
Implemented: Added support for adding and updating the email address of a facility and formatted the country code (#337)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Dec 19, 2024
@priyanshee1604 priyanshee1604 self-assigned this Jan 7, 2025
@priyanshee1604 priyanshee1604 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Jan 7, 2025
@priyanshee1604
Copy link
Contributor

priyanshee1604 commented Jan 7, 2025

ISSUES: Number validation is not implemented for the phone number field, allowing users to enter character values.
Opened a new issue for the same: #341

@priyanshee1604
Copy link
Contributor

Verified and confirmed that the following issues are resolved:

  1. Contact Email Address field is now available during facility creation.
  2. The correct format of the contact number is displayed on the OMS Facility Details page.
  3. "Owner ID Missing in the App": This idea was dropped as per the discussion and hence not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-v1.10.0
Projects
Archived in project
Development

No branches or pull requests

3 participants