Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select none as product store on settings page #367

Closed
1 of 2 tasks
ymaheshwari1 opened this issue Dec 7, 2023 · 4 comments
Closed
1 of 2 tasks

Unable to select none as product store on settings page #367

ymaheshwari1 opened this issue Dec 7, 2023 · 4 comments
Assignees
Labels
bug Something isn't working release-v2.6.0

Comments

@ymaheshwari1
Copy link
Contributor

Current behavior

When selecting none as product store, the store does not gets updated and the previous store is again selected.

Expected behavior

User should be able to select none as product store.

Steps to reproduce the issue

  • Go to settings page
  • Select None in product store option
  • Move to any other page and then again return to settings page
  • Verify that None is not selected and the previous store is selected

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

The issue is due to the check on https://github.com/hotwax/fulfillment-pwa/blob/main/src/views/Settings.vue#L522

@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Dec 7, 2023
@ymaheshwari1 ymaheshwari1 moved this to 📋 Backlog in Digital Experience Platform Dec 7, 2023
shanmukhdutt added a commit to shanmukhdutt/fulfillment-pwa that referenced this issue Dec 12, 2023
shanmukhdutt added a commit to shanmukhdutt/fulfillment-pwa that referenced this issue Dec 18, 2023
shanmukhdutt added a commit to shanmukhdutt/fulfillment-pwa that referenced this issue Dec 19, 2023
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Jan 9, 2024
@amansinghbais amansinghbais moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Jan 9, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 📋 Backlog in Digital Experience Platform Jan 16, 2024
@dt2patel
Copy link
Contributor

dt2patel commented Mar 9, 2024

I am not sure if user should be able to select none as an option during fulfillment process. When would user need to be completely independent of a product store for fulfillment? @ymaheshwari1

@ymaheshwari1
Copy link
Contributor Author

I am not sure if user should be able to select none as an option during fulfillment process. When would user need to be completely independent of a product store for fulfillment? @ymaheshwari1

I just created this as the option for the None is available for selection. But it makes sense that there is no need to have None option for product store.

@ymaheshwari1
Copy link
Contributor Author

We have concluded that we will remove the none option from the productStore selector.

@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jul 5, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jul 5, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Jul 5, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jul 5, 2024
ymaheshwari1 added a commit that referenced this issue Jul 9, 2024
Fixed: Removed the 'none' option from the productStore selector on settings page(#367)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 9, 2024
@R-Sourabh R-Sourabh removed their assignment Jul 15, 2024
@Adameddy26
Copy link

Adameddy26 commented Jul 16, 2024

Verified it in release v2.6.0 and found that this option of 'none' is now deprecated from the product store selection dropdown. Hence, closing this ticket.

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Jul 16, 2024
@Adameddy26 Adameddy26 self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-v2.6.0
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants