Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to select kit components while rejecting kit item #723

Closed
2 tasks
ravilodhi opened this issue Sep 3, 2024 · 3 comments
Closed
2 tasks

Add support to select kit components while rejecting kit item #723

ravilodhi opened this issue Sep 3, 2024 · 3 comments
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.8.1

Comments

@ravilodhi
Copy link
Contributor

Current behavior

Currently user can only reject kit without caring about it's component and the same inventory adjustments are done for the kit component as well.

Expected behavior

If cases the kit components are also sold individually, do not adjust their inventory based on the kit rejection and instead apply inventory adjustments only to the selected kit components. Add support in UI for the same. Default behaviour would to reject all the components.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@ravilodhi ravilodhi added the bug Something isn't working label Sep 3, 2024
@ravilodhi ravilodhi moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Sep 3, 2024
ravilodhi added a commit that referenced this issue Sep 3, 2024
@ravilodhi
Improved: Displayed checkbox on kit component if the kit product is m…
3e5a86f 
…arked for rejection (#723).
@ravilodhi ravilodhi mentioned this issue Sep 3, 2024
Merged
1 task
@ravilodhi ravilodhi moved this from 📅 Planned to 👀 In review in Digital Experience Platform Sep 3, 2024
ravilodhi added a commit that referenced this issue Sep 6, 2024
@ravilodhi
Improved: Removed kit component selection when rejection reason is re…
1c27b30 
…moved (#723).
ravilodhi added a commit that referenced this issue Sep 6, 2024
@ravilodhi
Merge pull request #724 from hotwax/#723_kit_component_rejection
233be09 
Improved: Displayed checkbox on kit component if the kit product is marked for rejection (#723).
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Sep 6, 2024
ravilodhi added a commit that referenced this issue Sep 9, 2024
@ravilodhi
Fixed: Passed selected components while rejecting kit (#723).
c817638
@ravilodhi ravilodhi mentioned this issue Sep 9, 2024
Merged
1 task
ravilodhi added a commit that referenced this issue Sep 9, 2024
@ravilodhi
Merge pull request #736 from hotwax/#723_kit_component_rejection
1f8b133 
Fixed: Passed selected  components while rejecting kit (#723).
ravilodhi added a commit that referenced this issue Sep 10, 2024
@ravilodhi
Fixed: Passed selected components while rejecting kit from order deta…
e58e119 
…il page (#723).
ravilodhi added a commit that referenced this issue Sep 10, 2024
@ravilodhi
Fixed: Passed selected components in the old API as well while reject…
8e57a78 
…ing kit (#723).
ravilodhi added a commit that referenced this issue Sep 10, 2024
@ravilodhi
Improved: Passed rejected component directly instead of passing as js…
3321518 
…on string (#723).
@ravilodhi ravilodhi mentioned this issue Sep 10, 2024
Merged
1 task
ravilodhi added a commit that referenced this issue Sep 10, 2024
@ravilodhi
Merge pull request #740 from hotwax/#723_kit_component_rejection
c0a31a7 
Improved: Passed rejected component directly instead of passing as json string (#723).
ravilodhi added a commit that referenced this issue Sep 10, 2024
@ravilodhi
Revert "Improved: Passed rejected component directly instead of passi…
1706f3c 
…ng as json string (#723)."
ravilodhi added a commit that referenced this issue Sep 10, 2024
@ravilodhi
Merge pull request #741 from hotwax/revert-740-#723_kit_component_rej…
435cb2c 
…ection

Revert "Improved: Passed rejected component directly instead of passing as json string (#723)."
ravilodhi added a commit that referenced this issue Sep 11, 2024
@ravilodhi
Improved: Passed selected component while rejecting kit in the desire…
a782b66 
…d format (#723).
@ravilodhi ravilodhi mentioned this issue Sep 11, 2024
Merged
1 task
ravilodhi added a commit that referenced this issue Sep 11, 2024
@ravilodhi
Merge pull request #743 from hotwax/#723_kit_component_rejection
36091d5 
Improved: Passed selected component while rejecting kit in the desired format (#723).
@Adameddy26 Adameddy26 self-assigned this Sep 11, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Sep 11, 2024
@Adameddy26
Copy link

Changes can only be verified on dev-oms and on dev-oms there is no kit product available. Therefore, marking this ticket on-hold.

@Adameddy26 Adameddy26 moved this from 🛠 In QA to 🛑 On hold in Digital Experience Platform Sep 12, 2024
@dt2patel
Copy link
Contributor

dt2patel commented Oct 4, 2024

Any room for movement here? When will se QA this?

@Adameddy26 Adameddy26 moved this from 🛑 On hold to 🛠 In QA in Digital Experience Platform Oct 8, 2024
@dt2patel dt2patel moved this to ⚒️ In QA in Digital Experience Platform Jan 14, 2025
@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

This is working in prod. closing ticket

@dt2patel dt2patel closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.8.1
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ravilodhi @dt2patel @Adameddy26