Update es.json #298
Closed
Update es.json #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am samuel from ADOC
ymaheshwari1
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Hi @Samux0112
Thanks for providing the translations.
Please check my comments once.
| "Generate shipping label": "Generar etiqueta de envío", | ||
| "Go to OMS": "Ir a OMS", | ||
| "Go to Launchpad": "Ir a Launchpad", | ||
| "is identified as unfulfillable. other containing this product will be unassigned from this store and sent to be rebrokered.": "{ productName } se identifica como no cumplible. { espacio } { orders } otros { orderText } que contienen este producto se desasignarán de esta tienda y se enviarán para ser revendidos.", |
There was a problem hiding this comment.
Please revert the translation for variables. All those entries that are in {}
| "Unpack": "Desempacar", | ||
| "Unpacking this order will send it back to 'In progress' and it will have to be repacked.": "Desempacar este pedido lo enviará de vuelta a 'En curso' y tendrá que ser vuelto a empacar.", | ||
| "Update": "Update", | ||
| "Update mapping": "Update mapping", |
There was a problem hiding this comment.
Please provide the translations for labels those are missing.
| "Store Name": "Nombre de la Tienda", | ||
| "Store SKU": "SKU de la Tienda", | ||
| "Supplementary documents": "Documentos adicionales", | ||
| "Tax Exempt": "Exento de impuestos", |
There was a problem hiding this comment.
Please remove the extra entries from the file.
|
ok let me change the json |
|
Closing as handled in #333 |
R-Sourabh
added a commit
to R-Sourabh/fulfillment-pwa
that referenced
this pull request
Jun 14, 2024
ymaheshwari1
added a commit
that referenced
this pull request
Jun 14, 2024
Updated: the Pull request template (dxp/298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am samuel from ADOC
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance