Implemented: barcode identifier selector and scanning based on selected identifier (#845) #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravilodhi
reviewed
Nov 7, 2024
src/views/Settings.vue
Outdated
| @@ -286,7 +289,8 @@ export default defineComponent({ | |||
| orderLimitType: 'unlimited', | |||
| fulfillmentOrderLimit: "" as number | string, | |||
| facilityGroupDetails: {} as any, | |||
| isEComInvEnabled: false | |||
| isEComInvEnabled: false, | |||
| barcodeContentMessage: translate("Only allow received quantity to be incremented by scanning the barcode of products. If the identifier is not found, the scan will default to using the internal name.", { space: '<br /><br />' }) | |||
There was a problem hiding this comment.
"Only allow received quantity......" should be changed to "Only allow shipped quantity"
ravilodhi
reviewed
Nov 7, 2024
src/store/modules/util/actions.ts
Outdated
| } | ||
| }, | ||
|
|
||
| async cretaBarcodeIdentificationPref({ commit }) { |
ymaheshwari1
requested changes
Nov 7, 2024
src/store/modules/util/UtilState.ts
Outdated
| @@ -13,4 +13,5 @@ export default interface UtilState { | |||
| facilities: any; | |||
| shipmentGatewayConfigs: any; | |||
| isForceScanEnabled: boolean; | |||
| barcodeIdentificationPref: any; | |||
There was a problem hiding this comment.
Suggested change
| barcodeIdentificationPref: any; | |
| barcodeIdentificationPref: string; |
src/store/modules/util/actions.ts
Outdated
| } | ||
|
|
||
| // not checking for resp success and fail case as every time we need to update the state with the | ||
| // default value when creating a scan setting |
There was a problem hiding this comment.
Suggested change
| // default value when creating a scan setting | |
| // default value when creating a store setting |
|
|
||
| async updateForceScanStatus({ commit }, payload) { | ||
| commit(types.UTIL_FORCE_SCAN_STATUS_UPDATED, payload) | ||
| }, | ||
|
|
||
| async updateBarcodeIdentificationPref({ commit }, payload) { |
There was a problem hiding this comment.
This action is not used anywhere, we should use this method wherever we are updating the state for barcode identifier, also we need to clear the barcode identifier value of logout.
src/store/modules/util/index.ts
Outdated
| @@ -21,7 +21,8 @@ const utilModule: Module<UtilState, RootState> = { | |||
| productStores: [], | |||
| facilities: [], | |||
| shipmentGatewayConfigs: [], | |||
| isForceScanEnabled: false | |||
| isForceScanEnabled: false, | |||
| barcodeIdentificationPref: "" | |||
There was a problem hiding this comment.
As we have defined internalName as default value for barcodeIdentifier we can have the same value here in state as its default declaration
…updated type, and updated comment (hotwax#845)
|
Closing this PR since latest commit got stuck in github glitch, Processing updates Created new PR for this: #851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#845
Short Description and Why It's Useful
Added support for the barcode identification scanning.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance