Skip to content

Commit

Permalink
Merge pull request #218 from sanskar345/import/#217
Browse files Browse the repository at this point in the history
Implemented: Replaced the usage of Image component with ShopifyImage component wherever the image is fetched from shopify
  • Loading branch information
ravilodhi authored Aug 25, 2023
2 parents f343fdf + a0a80dc commit c1f9faa
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
6 changes: 3 additions & 3 deletions src/components/MissingSkuModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<ion-list v-if="segmentSelected === 'completed'">
<ion-item v-for="item in getCompletedItems()" :key="item.shopifyProductSKU">
<ion-thumbnail slot="start">
<Image :src="item.imageUrl" />
<ShopifyImg :src="item.imageUrl" size="small" />
</ion-thumbnail>
<ion-label>
<p class="overline">{{ item.parentProductName }}</p>
Expand Down Expand Up @@ -92,7 +92,7 @@ import { closeOutline, saveOutline } from 'ionicons/icons';
import { defineComponent } from "@vue/runtime-core";
import { mapGetters, useStore } from "vuex";
import { ref } from "vue";
import Image from '@/components/Image.vue';
import { ShopifyImg } from "@hotwax/dxp-components";
export default defineComponent({
name: "MissingSkuModal",
Expand All @@ -117,7 +117,7 @@ export default defineComponent({
IonTitle,
IonThumbnail,
IonToolbar,
Image
ShopifyImg
},
data(){
return {
Expand Down
6 changes: 3 additions & 3 deletions src/components/PurchaseOrderDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<div class="list-item">
<ion-item lines="none">
<ion-thumbnail slot="start">
<Image :src="item.imageUrl" />
<ShopifyImg :src="item.imageUrl" size="small" />
</ion-thumbnail>
<ion-label class="ion-text-wrap">
<h3>{{ item.pseudoId }}</h3>
Expand Down Expand Up @@ -55,7 +55,7 @@
</div>
</template>
<script lang="ts">
import Image from '@/components/Image.vue';
import { ShopifyImg } from "@hotwax/dxp-components";
import {
IonCheckbox,
IonThumbnail,
Expand All @@ -82,7 +82,7 @@ export default defineComponent({
IonIcon,
IonItem,
IonLabel,
Image
ShopifyImg
},
props: {
purchaseOrders: {
Expand Down
1 change: 1 addition & 0 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const app = createApp(App)
.use(i18n)
.use(store)
.use(dxpComponents, {
defaultImgUrl: require("@/assets/images/defaultImage.png"),
login,
logout,
loader,
Expand Down
8 changes: 4 additions & 4 deletions src/views/InventoryReview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<div v-if="searchedProduct?.pseudoId" class="list-item">
<ion-item lines="none">
<ion-thumbnail>
<Image :src="searchedProduct.imageUrl" />
<ShopifyImg :src="searchedProduct.imageUrl" size="small" />
</ion-thumbnail>
<ion-label class="ion-text-wrap">
<h3>{{ searchedProduct.pseudoId }}</h3>
Expand Down Expand Up @@ -100,7 +100,7 @@
<div class="list-item">
<ion-item lines="none">
<ion-thumbnail slot="start">
<Image :src="item.imageUrl" />
<ShopifyImg :src="item.imageUrl" size="small" />
</ion-thumbnail>
<ion-label class="ion-text-wrap">
<h3>{{ item.pseudoId }}</h3>
Expand Down Expand Up @@ -142,7 +142,7 @@
</template>
<script lang="ts">
import { UploadService } from "@/services/UploadService";
import Image from '@/components/Image.vue';
import { ShopifyImg } from "@hotwax/dxp-components";
import ProductPopover from '@/components/ProductPopover.vue'
import BulkInventoryAdjustmentModal from '@/components/BulkInventoryAdjustmentModal.vue'
import MissingFacilitiesModal from '@/components/MissingFacilitiesModal.vue'
Expand All @@ -158,7 +158,7 @@ import { businessOutline, calculatorOutline, chevronForwardOutline, ellipsisVert
export default defineComponent({
name: 'InventoryDetail',
components: {
Image,
ShopifyImg,
IonPage,
IonHeader,
IonToolbar,
Expand Down

0 comments on commit c1f9faa

Please sign in to comment.