Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code to generate mapping id when creating a new mapping #166

Open
1 of 2 tasks
ymaheshwari1 opened this issue Feb 1, 2023 · 0 comments
Open
1 of 2 tasks
Assignees
Labels
bug Something isn't working

Comments

@ymaheshwari1
Copy link
Contributor

Current behavior

Currently, when creating a new mapping we are generating a random id for passing the same in the request, as the in parameter in the service is required.
But in current scenario as well, we are using the id returned from the api (which is an auto generated id) and we are using the same to identify the mappings.

Expected behavior

Need to remove the code for generating the id, once the id param will become optional

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Feb 1, 2023
@ymaheshwari1 ymaheshwari1 changed the title Remove code to generate mapping id Remove code to generate mapping id when creating a new mapping Feb 1, 2023
@ymaheshwari1 ymaheshwari1 moved this to 📋 Backlog in Digital Experience Platform Feb 1, 2023
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Nov 10, 2023
@ymaheshwari1 ymaheshwari1 removed their assignment Dec 19, 2023
@ravilodhi ravilodhi moved this from 📅 Planned to 👀 In review in Digital Experience Platform Nov 26, 2024
@ravilodhi ravilodhi self-assigned this Nov 26, 2024
ravilodhi added a commit that referenced this issue Dec 2, 2024
Improved: Removed generating  mapping id from client side when creating a new mapping (#166).
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ⏸️ Dev complete
Development

No branches or pull requests

3 participants