Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently we are passing externalFacilityId in the scheduled restock, but need to change it to facilityId #289

Closed
3 of 4 tasks
ymaheshwari1 opened this issue Jun 13, 2024 · 1 comment
Closed
3 of 4 tasks

Currently we are passing externalFacilityId in the scheduled restock, but need to change it to facilityId #289

ymaheshwari1 opened this issue Jun 13, 2024 · 1 comment
Assignees
@Adameddy26
Labels
enhancement New feature or request release-v2.18.1

Comments

@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Jun 13, 2024 •
edited
Loading

What is the motivation for adding/enhancing this feature?

As in the app, we are fetching all the facilities from the system then instead of passing externalId for facility, pass the facilityId.
Doing so, as there might be cases where externalFacilityId mapping is missing for some facility which will result in having issues in the overall process.

What are the acceptance criteria?

  • Pass facilityId in place of externalFacilityId when creating shipment, also update the parameter name from externalDestinationFacilityId to destinationFacilityId
  • Update the viewSize when fetching facilities to 250

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jun 13, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 👀 In review in Digital Experience Platform Jun 13, 2024
@R-Sourabh R-Sourabh moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Jun 13, 2024
R-Sourabh added a commit to R-Sourabh/import that referenced this issue Jun 13, 2024
@R-Sourabh
Updated: Replace externalId with facilityId in payload & increase the…
2106cdd 
… viewSize to 250. (hotwax#289)
@R-Sourabh R-Sourabh mentioned this issue Jun 13, 2024
Merged
1 task
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jun 13, 2024
ymaheshwari1 added a commit that referenced this issue Jul 17, 2024
@ymaheshwari1
Merge pull request #290 from R-Sourabh/#289-externalFacilityId-change
c83e525 
Improved: Replace externalFacilityId with facilityId in payload & increase the viewSize to 250 (#289)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 17, 2024
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned dongreparam Sep 16, 2024
@Adameddy26 Adameddy26 added enhancement New feature or request release-v2.18.1 labels Sep 16, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Sep 16, 2024
@Adameddy26
Copy link

Verified the changes and are working fine in release v2.18.1. Hence, closing this ticket.

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-v2.18.1
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ymaheshwari1 @R-Sourabh @dongreparam @Adameddy26