Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the selected mapping chip appear highlighted. #295

Closed
3 tasks
amansinghbais opened this issue Jul 9, 2024 · 2 comments
Closed
3 tasks

Make the selected mapping chip appear highlighted. #295

amansinghbais opened this issue Jul 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request release-v3.0.0

Comments

@amansinghbais
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently when we select any mapping field or create new mapping its chip dont appear as selected which creates confusion as which chip is selected.

Make the selected mapping chip appear highlighted for better user experience.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

@amansinghbais amansinghbais self-assigned this Jul 9, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jul 9, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jul 10, 2024
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jul 10, 2024
ymaheshwari1 added a commit that referenced this issue Jul 17, 2024
Implemented: logic to highlight the selected mapping chip (#295)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 17, 2024
@Adameddy26 Adameddy26 self-assigned this Sep 13, 2024
@Adameddy26 Adameddy26 added enhancement New feature or request release-v2.18.1 labels Sep 13, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Sep 13, 2024
@Adameddy26
Copy link

Verified in release v2.18.1 and found that when user closes the new mapping modal without any change then in that case highlighting gets removed from the chip.
Hence, reopening this issue.

@Adameddy26 Adameddy26 moved this from 🛠 In QA to 📅 Planned in Digital Experience Platform Sep 16, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 👀 In review in Digital Experience Platform Sep 18, 2024
ravilodhi added a commit that referenced this issue Sep 18, 2024
Fixed: event returing on modal dismiss from create mapping modal (#295)
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Sep 18, 2024
@priyanshee1604
Copy link

Verified the changes in the app's development environment and confirmed that the following scenarios are working as expected:

Case 1: When the user selects a mapping chip, it is displayed as selected/highlighted.
Case 2: When the user creates a new mapping, it is displayed as selected/highlighted.
Case 3 (Reopened Issue): If the user selects a saved mapping, opens the new mapping modal, and closes it without making any changes, the selection on the mapping remains intact.

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-v3.0.0
Projects
Archived in project
Development

No branches or pull requests

4 participants