Fixed: SAVE MAPPING button saves empty mapping when file not uploaded(#326re7p) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharma7
suggested changes
Dec 8, 2022
src/views/PurchaseOrder.vue
Outdated
| @@ -133,11 +133,20 @@ export default defineComponent({ | |||
| return !this.fieldMappings[id] ? id : this.generateUniqueMappingPrefId(); | |||
| }, | |||
| saveMapping() { | |||
| if (this.mappingName) { | |||
| if (this.mappingName && this.file && this.areAllFieldsSelected()) { | |||
| showToast(translate("Mapping saved successfully")); | |||
There was a problem hiding this comment.
It should after the operation completion
There was a problem hiding this comment.
yes sir. Fixed it
src/views/PurchaseOrder.vue
Outdated
| const mappingPrefId = this.generateUniqueMappingPrefId(); | ||
| this.store.dispatch('user/updateFieldMappings', { mappingPrefId, mappingPrefName: this.mappingName, mappingPrefValue: JSON.parse(JSON.stringify(this.fieldMapping)) }) | ||
| } else { | ||
| showToast(translate("Enter mapping name")); | ||
| if(!this.mappingName) { |
There was a problem hiding this comment.
We could add these conditions at the top and return control, if they are fulfilled. The code if then doesn't need any if else
| @@ -198,6 +207,9 @@ export default defineComponent({ | |||
| this.mappingName = fieldMapping.mappingPrefName; | |||
| } | |||
| }, | |||
| areAllFieldsSelected() { | |||
There was a problem hiding this comment.
We could use it for other use cases in the page
… name, earlier we were having two checks for missing mapping name, imcomplete field mapping or missing file upload in IF & ELSE block, now optimised code to do it in a single scope(#326re7p)
shashwatbangar
force-pushed
the
#326re7p
branch
from
6269e09 to
48f9f17
Compare
…tive logic on PurchaseOrder page(#326re7p)
…s called earlier without using this(#326re7p)
adityasharma7
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #110
Short Description and Why It's Useful
Now user can only save mapping if file is uploaded, a mapping name is provided & all fields are selected.
Screenshots of Visual Changes before/after (If There Are Any)
Screen.Recording.2022-12-05.at.12.25.02.PM.mov
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance