Implemented feature to import CSV to reset Inventory(#31a0f22) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cility location(#31a0f22)
…xed the UI of inventory detail page(#31a0f22)
This reverts commit 725b777.
…er upload action(#31a0f22)
…ing facilityId and added static text in en.json file(#31a0f22)
…elds is not mapped(#31a0f22)
…adjustment and other operations(#31a0f22)
…31a0f22) When navigating from Inventory review to PO import page, when the new file is upload code in inventory page is executed as the id was same.
When accessing the products from cached products, using it as object will be optimised approach when accessing any product using id. When returning cachedProducts object from fetchProducts method and accessing it we have an advantage of quick access, instead of returning list received Additionally: Fixed logic for viewSize when getting facility locations, instead of getting 10 location, it should be as per the no of facilityIds
Fetching facilities should be one time action on mounted, used cache to persist it for atleast 1 hour to avoid any unwanted API calls
- Fixed logic to set file if user cancels the file upload - Fixed values not getting reinitialised when logout and navigation to some other page
… externalId (#31a0f22) Fixed input file not reset with data properties Improved logic to check if response has error Used logger instead of console.error
We are using stock items term for imported stocks, for consistency same term should be used
…into disha1202-#31a0f22
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #98
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance