Added: extra product info in missing sku modal #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: product should update on enter fix: sku not updating in completed tab(#85zrpv6dd)
dt2patel
reviewed
Mar 6, 2023
src/components/MissingSkuModal.vue
Outdated
| @@ -41,8 +41,12 @@ | |||
| </ion-list> | |||
|
|
|||
| <ion-list v-if="segmentSelected === 'completed'"> | |||
| <ion-item v-for="item in getCompletedItems()" :key="item.shopifyProductSKU"> | |||
| <ion-item v-for="item in getCompletedItems()" :key="item.shopifyProductSKU" lines="full"> | |||
There was a problem hiding this comment.
why have we added lines="full"?
There was a problem hiding this comment.
Looked better with lines="full"
as compared to this
src/components/MissingSkuModal.vue
Outdated
| <ion-label> | ||
| <p>{{ item.parentProductName }}</p> |
There was a problem hiding this comment.
Use class="overline" whenever placing content about the primary piece of info in an ion-item
adityasharma7
approved these changes
Mar 28, 2023
adityasharma7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Changes:
fix: product should update on enter
fix: sku not updating in completed tab(#85zrpv6dd)
Related Issues
Closes #198 #199
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance