Implemented revert functionality#22xdxhp #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/ProductPopover.vue
Outdated
| @@ -31,6 +32,9 @@ export default defineComponent({ | |||
| }), | |||
| }, | |||
| methods: { | |||
| onlyRevert() { | |||
| this.isVirtual ? this.onlyRevertSingleProduct() : this.onlyRevertParentProduct(); | |||
There was a problem hiding this comment.
If isVirtual means it is virtual product, I think we should use onlyRevertParentProduct and for variant we should use onlyRevertSingleProduct
There was a problem hiding this comment.
Updated the code.
adityasharma7
suggested changes
Mar 28, 2022
src/components/ProductPopover.vue
Outdated
| @@ -31,6 +32,9 @@ export default defineComponent({ | |||
| }), | |||
| }, | |||
| methods: { | |||
| onlyRevert() { | |||
There was a problem hiding this comment.
Suggested change
| onlyRevert() { | |
| revert() { |
There was a problem hiding this comment.
Made the requested change.
src/components/ProductPopover.vue
Outdated
| @@ -45,12 +49,41 @@ export default defineComponent({ | |||
| element.isSelected = element.internalName === this.id; | |||
| }); | |||
| popoverController.dismiss({ dismissed: true }); | |||
| }, | |||
| onlyRevertSingleProduct() { | |||
There was a problem hiding this comment.
Suggested change
| onlyRevertSingleProduct() { | |
| revertProduct() { |
There was a problem hiding this comment.
Made the requested change.
src/components/ProductPopover.vue
Outdated
| this.store.dispatch('order/updatedOrderListItems', items) | ||
| popoverController.dismiss({ dismissed: true }); | ||
| }, | ||
| onlyRevertParentProduct(){ |
There was a problem hiding this comment.
Suggested change
| onlyRevertParentProduct(){ | |
| revertParentProduct(){ |
There was a problem hiding this comment.
Made the requested change.
src/views/OrderDetail.vue
Outdated
| @@ -329,6 +329,10 @@ export default defineComponent({ | |||
| selectProduct(item: any, event: any) { | |||
| item.isSelected = event.detail.checked; | |||
| }, | |||
| revertAllChanges() { | |||
There was a problem hiding this comment.
Suggested change
| revertAllChanges() { | |
| revertAll() { |
There was a problem hiding this comment.
Made the requested change.
ymaheshwari1
requested changes
Mar 29, 2022
changelogs/unreleased/-22xdxhp.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| title: Implemented revert functionality(#22xdxhp) | |||
There was a problem hiding this comment.
Remove ticket id from changelog.
adityasharma7
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.