Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Page Selection Persistence for Import App with Side Navigation(#122) #224

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Aug 16, 2023

Related Issues

Related Issues: hotwax/dxp-components#122

Short Description and Why It's Useful

Fixed issue of menu not being enabled for the correct page when using the back button in Import app.

  • Removed a watcher from the menu component that checks for route changes.
  • Defined a computed property to find the correct index in the menu list.
  • Added an entry in the menu component pages to list all the child routes those are not listed in the menu for a specific parent route, using which we have enabled the correct menu in the UI.
  • Added a logic for the dynamic child routes in the app.

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/components/Menu.vue Outdated Show resolved Hide resolved
@ravilodhi ravilodhi merged commit f343fdf into hotwax:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants