Block user navigating to details page if no records after review action(#24pp0fm) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Apr 8, 2022
src/views/PurchaseOrder.vue
Outdated
| name:'PurchaseOrderDetail' | ||
| }) | ||
| } else { | ||
| showToast(translate("Something went wrong")); |
There was a problem hiding this comment.
if this is an error message just for this condition, we should specifically say:
"Please upload a purchase order to continue"
There was a problem hiding this comment.
Updated the message for case when file is not uploaded.
…t when file is not uploaded(#24pp0fm)
adityasharma7
suggested changes
Oct 27, 2022
src/views/PurchaseOrder.vue
Outdated
| return field === ""; | ||
| }); | ||
| if (this.content.length <= 0) { | ||
| showToast(translate("Please upload a purchase order to continue")); |
There was a problem hiding this comment.
Suggested change
| showToast(translate("Please upload a purchase order to continue")); | |
| showToast(translate("Please upload a valid purchase order csv to continue")); |
There was a problem hiding this comment.
Made the requested change.
| name:'PurchaseOrderDetail' | ||
| }) | ||
| } else { | ||
| showToast(translate("Select all the fields to continue")); |
There was a problem hiding this comment.
Add both the text to en.json
There was a problem hiding this comment.
Added static text in en.json file
ymaheshwari1
requested changes
Oct 31, 2022
ymaheshwari1
approved these changes
Oct 31, 2022
adityasharma7
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65