Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented: timeZone switcher component from dxp package(dxp/262) #276

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Implemented: timeZone switcher component from dxp package(dxp/262) #276

merged 5 commits into from
Apr 2, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Mar 28, 2024 •
edited
Loading

Related Issues

hotwax/dxp-components#262

Short Description and Why It's Useful

  • Integrated the timeZone component from dxp-component into the application.
  • Removed the setUserTimeZone and getAvailableTimeZones methods from userService and started using them from @hotwax/oms-api.
  • Enhanced the setUserTimeZone action, making it synchronous for improved functionality.
  • Updated the settings section by replacing the timeZone settings and incorporating the DxpTimeZoneSwitcher component from dxp-components.
  • Updated the UI to display both the selected timezone and the browser timezone.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-04-01 19-06-54

  • UPDATED UI

Screenshot from 2024-04-01 18-59-41
Screenshot from 2024-04-01 19-01-31

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

@R-Sourabh R-Sourabh marked this pull request as ready for review April 1, 2024 09:13
@ymaheshwari1 ymaheshwari1 merged commit 2913434 into hotwax:main Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymaheshwari1 ymaheshwari1 ymaheshwari1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R-Sourabh @ymaheshwari1