Implemeted Static UI for displaying parsed csv and Implemented logic … #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to map parsed Csv and implemented order state(#22c8vf8)
dt2patel
requested changes
Feb 27, 2022
| .filters { | ||
| grid-area: filters; | ||
| } | ||
| .list-item{ |
There was a problem hiding this comment.
this is ok for now but add a note that this code needs to be updated to use universal list item class
adityasharma7
suggested changes
Feb 28, 2022
| @@ -0,0 +1,6 @@ | |||
| export default interface OrderState { | |||
| order: { | |||
There was a problem hiding this comment.
I think we should have state like this
list: {
items: [],
original: []
},
| import RootState from "../../RootState"; | ||
|
|
||
| const getters: GetterTree<OrderState, RootState> = { | ||
| getCsv(state){ |
There was a problem hiding this comment.
Suggested change
| getCsv(state){ | |
| getOrdeItems(state){ |
| import * as types from './mutation-types' | ||
|
|
||
| const actions: ActionTree<OrderState, RootState> = { | ||
| uploadCsv({commit}, payload){ |
There was a problem hiding this comment.
Suggested change
| uploadCsv({commit}, payload){ | |
| updateOrderList({commit}, payload){ |
| @@ -0,0 +1,2 @@ | |||
| export const SN_ORDER = 'order' | |||
| export const UPLOAD_CSV = SN_ORDER + '/UPLOAD_CSV' | |||
There was a problem hiding this comment.
Suggested change
| export const UPLOAD_CSV = SN_ORDER + '/UPLOAD_CSV' | |
| export const ORDER_LIST_UPDATED = SN_ORDER + '/LIST_UPDATED' |
ymaheshwari1
requested changes
Mar 4, 2022
| @@ -32,6 +33,12 @@ const routes: Array<RouteRecordRaw> = [ | |||
| component: PurchaseOrder, | |||
| beforeEnter: authGuard | |||
| }, | |||
| { | |||
| path: '/purchase-order-detail', | |||
| name: 'Purchase Order Detail', | |||
There was a problem hiding this comment.
Suggested change
| name: 'Purchase Order Detail', | |
| name: 'PurchaseOrderDetail', |
| const actions: ActionTree<RootState, RootState> = {} | ||
| const actions: ActionTree<RootState, RootState> = { | ||
|
|
||
| } |
There was a problem hiding this comment.
Remove these unwanted changes.
|
|
||
| const actions: ActionTree<OrderState, RootState> = { | ||
| uploadCsv({commit}, payload){ | ||
| commit(types.UPLOAD_CSV, payload ); |
There was a problem hiding this comment.
Suggested change
| commit(types.UPLOAD_CSV, payload ); | |
| commit(types.UPLOAD_CSV, payload); |
| } | ||
| }, | ||
| [types.PRODUCT_ADD_TO_CACHED_MULTIPLE] (state, payload) { | ||
| // TODO |
There was a problem hiding this comment.
I think we can remove these TODO.
| <ion-select-option>Backorder</ion-select-option> | ||
| </ion-select> | ||
| </ion-item> | ||
| <ion-button expand="block" fill="outline">Apply</ion-button> |
There was a problem hiding this comment.
Internationalize text.
| import { IonPage, IonHeader, IonToolbar, IonBackButton, IonTitle, IonContent, IonSearchbar, IonItem, IonThumbnail, IonLabel, IonInput, IonChip, IonIcon, IonButton, IonCheckbox, IonSelect, IonSelectOption } from '@ionic/vue' | ||
| import { ellipsisVerticalOutline, sendOutline } from 'ionicons/icons' | ||
| export default defineComponent({ | ||
| components: { |
There was a problem hiding this comment.
Change indentation to 2 spaces.
|
Changes merged with #8. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to map parsed Csv and implemented order state(#22c8vf8)