Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: facilityName should be displayed instead of facilityId in store selection along with Store as label ( #21fn6e5 ). #6

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Improved: facilityName should be displayed instead of facilityId in store selection along with Store as label ( #21fn6e5 ). #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91ddac9
Changed: 'facilityId' with 'facilityName' and 'selected-text' with 'v…
meet-aniket Feb 24, 2022
ea4f056
Added: changelog on PR (#21fn6e5).
meet-aniket Feb 24, 2022
f68b5c5
Changed: author-name on changelog (#21fn6e5).
meet-aniket Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/unreleased/-21fn6e5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: 'Changed: facilityId with facilityName and selected-text with value'
ticket_id: "#21fn6e5"
merge_request: 6
author: aniket
type: changed
6 changes: 3 additions & 3 deletions src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
<!-- Select store -->
<ion-item>
<ion-icon :icon="storefrontOutline" slot="start" />
<ion-label>{{ currentFacility.facilityId ? currentFacility.facilityId : '' }}</ion-label>
<ion-select interface="popover" :placeholder="$t('store name')" :selected-text="currentFacility.facilityId" @ionChange="setFacility($event)">
<ion-select-option v-for="facility in ( userProfile && userProfile.facilities ? userProfile.facilities : [] )" :key="facility.facilityId" :value="facility.facilityId" >{{ facility.facilityId }}</ion-select-option>
<ion-label>{{ $t("Store") }}</ion-label>
<ion-select interface="popover" :placeholder="$t('store name')" :value="currentFacility.facilityId" @ionChange="setFacility($event)">
<ion-select-option v-for="facility in ( userProfile && userProfile.facilities ? userProfile.facilities : [] )" :key="facility.facilityId" :value="facility.facilityId" >{{ facility.name }}</ion-select-option>
</ion-select>
</ion-item>
<!-- OMS information -->
Expand Down