Implemented logic for storing and applying multiple field mappings(#2hran7u) #84

disha1202 · 2022-11-01T09:59:44Z

Related Issues

Closes #81

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

screen-recorder-fri-nov-04-2022-12-57-09.webm

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

I read and followed contribution rules

…hran7u)

src/views/PurchaseOrder.vue

…-updated

adityasharma7 · 2022-11-03T05:27:42Z

src/store/modules/user/mutations.ts

@@ -19,6 +19,14 @@ const mutations: MutationTree <UserState> = {
    },
    [types.USER_INSTANCE_URL_UPDATED] (state, payload) {
        state.instanceUrl = payload;
+    },
+    [types.USER_FIELD_MAPPINGS_UPDATED] (state, payload) {
+        const mapping = state.fieldMappings.find((mapping: any) => mapping.name === payload.name );


I think this should be part of action

Updated the code.

adityasharma7 · 2022-11-03T05:29:56Z

src/views/PurchaseOrder.vue

+        fields: {
+          orderId: "",
+          productSku: "",
+          date: "",


Suggested change

date: "",

orderDate: "",

Updated the variable name

adityasharma7 · 2022-11-03T05:47:40Z

src/store/modules/user/index.ts

@@ -12,6 +12,7 @@ const userModule: Module<UserState, RootState> = {
      current: null,
      currentFacility: {},
      instanceUrl: '',
+      fieldMappings: []


We could have it as object with key as mappingPrefId and value as object having mappingPrefId, mappingPrefName, mappingPrefTypeEnumId and mappingPrefValue

Created it as an object with key as mapping name and value as mapping fields.

adityasharma7 · 2022-11-03T05:54:29Z

src/views/PurchaseOrder.vue

-        dateField: "",
-        quantityField: "",
-        facilityField: "",
+        fields: {


Why not fieldMapping?

Updated the variable name

adityasharma7 · 2022-11-03T05:56:44Z

src/views/PurchaseOrder.vue

+          const mapping = JSON.parse(JSON.stringify(event.detail.value));
+          this.fields = mapping.fieldMapping;
+          this.mappingName = mapping.name;
+        }
        this.orderItemsList = this.content.map(item => {


I think this should be done with review only

Made the requested change.

adityasharma7 · 2022-11-03T05:56:49Z

src/views/PurchaseOrder.vue

+      mapFields(event) {
+        if(event && event.detail.value){
+          const mapping = JSON.parse(JSON.stringify(event.detail.value));
+          this.fields = mapping.fieldMapping;


Suggested change

this.fields = mapping.fieldMapping;

this.fields = mapping.fieldMapping;

adityasharma7 · 2022-11-03T05:57:12Z

src/views/PurchaseOrder.vue

+          name:'PurchaseOrderDetail'
+        })
+      },
+      mapFields(event) {


We could check if mapping fields exist in csv

Made the requested change.
Also displayed a toast if any of the fields is missing.

adityasharma7 · 2022-11-03T06:00:25Z

@disha1202

Could you please share some screenshots and videos for the change?

…into #2hran7u-updated

…sv(#2hran7u-updated)

… csv(#2hran7u)

disha1202 · 2022-11-04T09:53:00Z

@disha1202

Could you please share some screenshots and videos for the change?

Sure Sir, added in the PR description.

…-updated

…PrefId(#2hran7u)

…into #2hran7u-updated

…gPrefids(#2hran7u)

adityasharma7 · 2022-11-21T09:30:59Z

src/views/PurchaseOrder.vue

        orderItemsList: [],
      }
    },
    methods: {
+      saveMapping() {
+        if (this.mappingName) {
+          const mappingPrefId = Math.floor(Math.random() * 1000);


I think we should check if the id already exists.

adityasharma7 · 2022-11-21T11:04:02Z

src/views/PurchaseOrder.vue

        orderItemsList: [],
      }
    },
    methods: {
+      generateUniqueId(id) {


Improve method name, this is not generic method to generate id for any use case

…-updated

… field mapping applied(#2hran7u)

adityasharma7 · 2022-11-21T13:05:26Z

src/views/PurchaseOrder.vue

+        if(event && event.detail.value) {
+          const fieldMapping = JSON.parse(JSON.stringify(event.detail.value));
+          for(const field in fieldMapping.mappingPrefValue){
+            if(!Object.keys(this.content[0]).includes(fieldMapping.mappingPrefValue[field])) fieldMapping.mappingPrefValue[field] = "";


We could store Object.keys(this.content[0]) to reuse

adityasharma7 · 2022-11-21T13:09:07Z

src/views/PurchaseOrder.vue

+      mapFields(event) {
+        if(event && event.detail.value) {
+          const fieldMapping = JSON.parse(JSON.stringify(event.detail.value));
+          for(const field in fieldMapping.mappingPrefValue){


We could use reduce() here

…-updated

…into #2hran7u-updated

adityasharma7 · 2022-11-22T05:17:57Z

src/views/PurchaseOrder.vue

+          const missingFields = Object.values(fieldMapping.mappingPrefValue).filter(field => {
+            if(!Object.keys(this.content[0]).includes(field)) return field;
+          });
+          if(missingFields.length) showToast(translate(`Some of the mapping fields are missing in the CSV: \n ${ missingFields.join(", ") }`))


I think we could pass missingFields as variable
Refer this code
https://github.com/hotwax/preorder/blob/main/src/views/product-details.vue#L347

disha1202 added 2 commits November 1, 2022 15:28

Implemented logic for storing and applying multiple field mappings(#2…

4df3d0c

…hran7u)

Improved code(#2hran7u)

ae4e4cb

disha1202 requested a review from ymaheshwari1 November 1, 2022 10:03

Updated markup(#2hran7u)

42b8699

ymaheshwari1 requested changes Nov 1, 2022

View reviewed changes

src/views/PurchaseOrder.vue Outdated Show resolved Hide resolved

src/views/PurchaseOrder.vue Outdated Show resolved Hide resolved

src/views/PurchaseOrder.vue Outdated Show resolved Hide resolved

src/views/PurchaseOrder.vue Outdated Show resolved Hide resolved

Improved code(#2hran7u)

94e490c

ymaheshwari1 requested changes Nov 1, 2022

View reviewed changes

src/views/PurchaseOrder.vue Outdated Show resolved Hide resolved

disha1202 added 3 commits November 1, 2022 18:00

Fixed: typo and unwanted mutation of mappings(#2hran7u)

6cdc753

Merge branch 'main' of https://github.com/hotwax/import into #2hran7u…

737b818

…-updated

Reverted unwanted changes(#2hran7u)

39a275d

ymaheshwari1 approved these changes Nov 2, 2022

View reviewed changes

disha1202 requested a review from adityasharma7 November 2, 2022 09:55

adityasharma7 reviewed Nov 3, 2022

View reviewed changes

adityasharma7 suggested changes Nov 3, 2022

View reviewed changes

Merge branch 'main' into #2hran7u-updated

d0b73a3

disha1202 added 4 commits November 4, 2022 12:59

Improved code and variable name(#2hran7u)

c6ce6d2

Merge branch '#2hran7u-updated' of https://github.com/disha1202/import …

5a00df2

…into #2hran7u-updated

Updated code to display toast if mapped fields are not found in the c…

8e3c6bb

…sv(#2hran7u-updated)

Improved logic to verify whether all the mapped fields are present in…

5a2f32c

… csv(#2hran7u)

disha1202 requested a review from adityasharma7 November 8, 2022 05:51

disha1202 and others added 3 commits November 16, 2022 18:26

Merge branch 'main' of https://github.com/hotwax/import into #2hran7u…

3eb3ff1

…-updated

Removed unwanted code(#2hran7u)

630e83b

Merge branch 'main' into #2hran7u-updated

3585673

disha1202 requested review from shashwatbangar and alsoK2maan November 18, 2022 10:51

adityasharma7 and others added 3 commits November 18, 2022 16:43

Merge branch 'main' into #2hran7u-updated

27cc673

Implemented logic to store mappings corresponding to a unique mapping…

6ceb077

…PrefId(#2hran7u)

Merge branch '#2hran7u-updated' of https://github.com/disha1202/import …

84d8b94

…into #2hran7u-updated

disha1202 added 4 commits November 21, 2022 15:50

Removed unwanted code and implemented logic to generate unique mappin…

42171a2

…gPrefids(#2hran7u)

Fixed: code to generate unique mappingPrefId(#2hran7u)

59c1734

Removed unwanted code (#2hran7u)

3efaddd

Updated method name(#2hran7u)

fe85692

adityasharma7 suggested changes Nov 21, 2022

View reviewed changes

disha1202 added 5 commits November 21, 2022 16:59

Merge branch 'main' of https://github.com/hotwax/import into #2hran7u…

8afb009

…-updated

Resolved merge conflicts(#2hran7u)

25679b6

Fixed: wrong variable name(#2hran7u)

2872014

Updated code to block user navigation if the csv does not contain the…

360a5c0

… field mapping applied(#2hran7u)

Improved code and added comments(#2hran7u)

13c0adc

adityasharma7 suggested changes Nov 21, 2022

View reviewed changes

adityasharma7 and others added 5 commits November 21, 2022 19:16

Merge branch 'main' into #2hran7u-updated

8501490

Updated toast message(#2hran7u)

e364e3c

Merge branch 'main' of https://github.com/hotwax/import into #2hran7u…

4af7188

…-updated

Merge branch '#2hran7u-updated' of https://github.com/disha1202/import …

bf71aba

…into #2hran7u-updated

Added missing import(#2hran7u)

71c23cd

adityasharma7 suggested changes Nov 22, 2022

View reviewed changes

adityasharma7 merged commit 71c23cd into hotwax:main Nov 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented logic for storing and applying multiple field mappings(#2hran7u) #84

Implemented logic for storing and applying multiple field mappings(#2hran7u) #84

disha1202 commented Nov 1, 2022 •

edited

Loading

adityasharma7 Nov 3, 2022

disha1202 Nov 4, 2022

adityasharma7 Nov 3, 2022

disha1202 Nov 4, 2022

adityasharma7 Nov 3, 2022

disha1202 Nov 4, 2022

adityasharma7 Nov 3, 2022

disha1202 Nov 4, 2022

adityasharma7 Nov 3, 2022

disha1202 Nov 4, 2022

adityasharma7 Nov 3, 2022

adityasharma7 Nov 3, 2022

disha1202 Nov 4, 2022

adityasharma7 commented Nov 3, 2022

disha1202 commented Nov 4, 2022

adityasharma7 Nov 21, 2022

adityasharma7 Nov 21, 2022

adityasharma7 Nov 21, 2022

adityasharma7 Nov 21, 2022

adityasharma7 Nov 22, 2022

	this.fields = mapping.fieldMapping;
	this.fields = mapping.fieldMapping;

Implemented logic for storing and applying multiple field mappings(#2hran7u) #84

Implemented logic for storing and applying multiple field mappings(#2hran7u) #84

Conversation

disha1202 commented Nov 1, 2022 • edited Loading

Related Issues

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adityasharma7 commented Nov 3, 2022

disha1202 commented Nov 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

disha1202 commented Nov 1, 2022 •

edited

Loading