Implemented logic to display an alert before route change(#2ymay5f) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
approved these changes
Nov 7, 2022
adityasharma7
suggested changes
Nov 14, 2022
| isParentProductUpdated: false | ||
| } | ||
| }, | ||
| ionViewDidEnter(){ | ||
| this.fetchFacilities(); | ||
| }, | ||
| async beforeRouteLeave(to, from) { | ||
| const alert = await alertController.create({ | ||
| header: this.$t("Leave page"), |
There was a problem hiding this comment.
Add all the text to en.json
There was a problem hiding this comment.
The text is already added in en.json file
src/views/OrderDetail.vue
Outdated
| @@ -206,12 +206,38 @@ export default defineComponent({ | |||
| facilities: [] as any, | |||
| queryString: "", | |||
| searchedProduct: {} as any, | |||
| canLeave: false, | |||
There was a problem hiding this comment.
We could use a local variable
adityasharma7
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #78
Short Description and Why It's Useful
If the user switches to another page, like the settings page, while reviewing their PO, when they return to the upload screen they land on the file upload screen which is disorienting.
Implemented a pop up that warns the user that if they switch to another screen while reviewing their PO, that their changes will be lost and they'll have to restart.
Screenshots of Visual Changes before/after (If There Are Any)
screen-recorder-fri-nov-04-2022-16-42-17.webm
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance