Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shop selector to menu footer #129

Closed
1 task
dt2patel opened this issue May 6, 2022 · 0 comments · Fixed by #243 or #283
Closed
1 task

Add shop selector to menu footer #129

dt2patel opened this issue May 6, 2022 · 0 comments · Fixed by #243 or #283
Assignees
@adityasharma7
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dt2patel
Copy link
Contributor

dt2patel commented May 6, 2022

What is the motivation for adding/enhancing this feature?

The shop name and other instance info is shown in the footer of the menu. It feels very natural to click it and change the selected shop.

What are the acceptance criteria?

Clicking the ship info in the footer should open an inline popover that lets the user select their shop that they would otherwise have to go into the settings page for.

  • ...

Screen Shot 2022-05-06 at 11 24 27 AM
@dt2patel dt2patel added enhancement New feature or request good first issue Good for newcomers labels May 6, 2022
@disha1202 disha1202 mentioned this issue Oct 28, 2022
Merged
1 task
@disha1202 disha1202 moved this to 👀 In review in Digital Experience Platform Oct 28, 2022
@disha1202 disha1202 assigned disha1202 and ymaheshwari1 and unassigned disha1202 Nov 1, 2022
@alsoK2maan alsoK2maan mentioned this issue Nov 17, 2022
Merged
1 task
@alsoK2maan alsoK2maan moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Dec 5, 2022
@alsoK2maan alsoK2maan moved this from 🏗 In progress to ✋Hold in Digital Experience Platform Dec 5, 2022
@alsoK2maan alsoK2maan moved this from ✋Hold to 🏗 In progress in Digital Experience Platform Dec 5, 2022
@alsoK2maan alsoK2maan moved this from 🏗 In progress to ✋Hold in Digital Experience Platform Dec 6, 2022
@alsoK2maan alsoK2maan moved this from ✋Hold to 👀 In review in Digital Experience Platform Dec 6, 2022
Repository owner moved this from 👀 In review to ✅ Done in Digital Experience Platform Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityasharma7 adityasharma7

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
5 participants
@adityasharma7 @ymaheshwari1 @disha1202 @alsoK2maan @dt2patel