Added shop selector to menu footer (#2a7ymj3) #283
Conversation
…efined and passes event instead of undefined on refresh job(#2a7ymj3)
…n error (#2a7ymj3)
|
@k2maan |
|
@adityasharma7 sir, the more jobs section works as expected with the shop selector footer. |
alsoK2maan
assigned adityasharma7 and alsoK2maan and unassigned alsoK2maan and adityasharma7
| "enumTypeId": "ORDER_SYS_JOB" | ||
| } | ||
| }); | ||
| this.store.dispatch("job/fetchJobs", { |
There was a problem hiding this comment.
I think batch jobs should have enumTypeId as ORDER_SYS_JOB and we are already fetching those jobs
There was a problem hiding this comment.
Sir, the More Jobs section is not visible if we remove the code.
src/views/Miscellaneous.vue
Outdated
| @@ -145,7 +147,6 @@ export default defineComponent({ | |||
| async refreshJobs(event: any) { | |||
There was a problem hiding this comment.
'event' is defined but never used
| if(this.segmentSelected === 'pending') { | ||
| this.getPendingJobs().then(() => { | ||
| if(event) event.target.complete(); |
There was a problem hiding this comment.
Check if it is not breaking pull to refresh (ion-refresher)
https://ionicframework.com/docs/api/refresher#complete
There was a problem hiding this comment.
I tried "pull to refresh" on Pipeline page & loader keeps on spinning.
There was a problem hiding this comment.
Yes, it's running infinitely. How should I proceed now?
There was a problem hiding this comment.
We could pass event as undefined for all the other cases then pull to refresh
| if(this.segmentSelected === 'pending') { | ||
| this.getPendingJobs().then(() => { | ||
| if(event) event.target.complete(); |
There was a problem hiding this comment.
We could pass event as undefined for all the other cases then pull to refresh
…te() and passing event as undefined on button clicks (#2a7ymj3)
Related Issues
Closes #129
Short Description and Why It's Useful
Implemented changes to resolve infinite loading spinner on refreshJobs.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance