Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the positioning of the radio items label in the customFrequency modal. #714

Closed
2 tasks
amansinghbais opened this issue Jul 1, 2024 · 1 comment
Closed
2 tasks

Fix the positioning of the radio items label in the customFrequency modal. #714

amansinghbais opened this issue Jul 1, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.24.0

Comments

@amansinghbais
Copy link
Contributor

Current behavior

Both the lable and the radio button is coming at the start of the item which is looking distorted.

Expected behavior

Fix the positioning of the ion-radio items label and the circleOutline.

Screenshot

Screenshot from 2024-07-01 15-03-07

Steps to reproduce the issue

  1. Open job-configuration of any job in Pipeline page.
  2. Select the custom option in frequency selector. Custom frequency modal is open up.
  3. You can see that both radio label and circle outline are coming at the start of the item.

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@amansinghbais amansinghbais added the bug Something isn't working label Jul 1, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jul 11, 2024
@Ridwan6947 Ridwan6947 mentioned this issue Jul 11, 2024
Closed
1 task
Ridwan6947 added a commit to Ridwan6947/job-manager that referenced this issue Jul 12, 2024
@Ridwan6947
Improved: found a better approach by changing label placement and add…
b464546 
…ing justify to adjust positioning (hotwax#714)
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 👀 In review in Digital Experience Platform Jul 31, 2024
@dt2patel dt2patel moved this from 👀 In review to 📅 Planned in Digital Experience Platform Sep 4, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Sep 5, 2024
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Sep 5, 2024
@R-Sourabh
Fixed: positioning of the ion-radio items label and the circleOutline(h…
1f0b590 
…otwax#714)
@R-Sourabh R-Sourabh mentioned this issue Sep 5, 2024
Merged
1 task
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Sep 5, 2024
ymaheshwari1 added a commit that referenced this issue Sep 6, 2024
@ymaheshwari1
Merge pull request #727 from R-Sourabh/#714-radio-items-position
92b4dc9 
Fixed: positioning of the ion-radio items label and the circleOutline(#714)
@ymaheshwari1 ymaheshwari1 moved this to 👀 In review in Digital Experience Platform Sep 6, 2024
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Sep 6, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Oct 15, 2024
@Adameddy26 Adameddy26 self-assigned this Oct 15, 2024
@Adameddy26
Copy link

Verified and working fine in release v2.24.0. Hence, closing this issue.

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.24.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amansinghbais @R-Sourabh @Adameddy26