Implemented: Add shop selector to menu footer(#2a7ymj3) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayank909
changed the title
ymaheshwari1
requested changes
May 11, 2022
src/views/Pipeline.vue
Outdated
| @@ -384,18 +384,27 @@ export default defineComponent({ | |||
| this.store.dispatch('job/fetchPendingJobs', {eComStoreId: this.getCurrentEComStore.productStoreId, viewSize:process.env.VUE_APP_VIEW_SIZE, viewIndex:0}).then(() => { | |||
| if(event) event.target.complete(); | |||
| this.isRetrying = false; | |||
| emitter.off("selectedShop",this.refreshJobs); | |||
| }).catch(()=>{ | |||
There was a problem hiding this comment.
Why we used catch here?
There was a problem hiding this comment.
Sir, When the promise is resolved It goes into the 'then' block. If 'then' returns a rejected promise, it goes to catch block. That's why I use the catch here.
ymaheshwari1
requested changes
May 16, 2022
ymaheshwari1
requested changes
May 16, 2022
ymaheshwari1
requested changes
May 16, 2022
ymaheshwari1
requested changes
May 19, 2022
ymaheshwari1
requested changes
May 23, 2022
src/views/Pipeline.vue
Outdated
| @@ -445,16 +445,22 @@ export default defineComponent({ | |||
| this.getPendingJobs().then(() => { | |||
| if(event) event.target.complete(); | |||
| this.isRetrying = false; | |||
| }).catch(()=>{ | |||
| this.isRetrying = false; | |||
There was a problem hiding this comment.
Why we have changed this?
There was a problem hiding this comment.
Sir, I used catch block here because when I ran this code at that time the spinner of the retry button was not stoping
and a rejected promise error came, that's why. I handle it in the catch block.
adityasharma7
suggested changes
May 26, 2022
adityasharma7
suggested changes
May 26, 2022
src/views/Pipeline.vue
Outdated
| @@ -439,23 +439,23 @@ export default defineComponent({ | |||
| event.target.complete(); | |||
| }) | |||
| }, | |||
| async refreshJobs(event: any) { | |||
| this.isRetrying = true; | |||
| async refreshJobs(event: any, retry = false ) { | |||
There was a problem hiding this comment.
Suggested change
| async refreshJobs(event: any, retry = false ) { | |
| async refreshJobs(event: any, isRetrying = false ) { |
adityasharma7
approved these changes
May 26, 2022
|
Need to update the value of autoCancelDays as well on productStore change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance
vide.mp4