Implemented: feature for user authorisation (#2ebg32y) #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with CASL library (#2ebg32y) 1. Implmented logic to define ability globaly and set it on login/logout 2. Implemented logic to check if user has update Job permission for pipeline skip and cancel action
Implmented defineAbilityForUser method to define permissions for user and used in during login/logout Added ACTIONS and SUBJECTS constant to ensure consistency of values set for permissions
…d Action (#2ebg32y)
…CTS constant to check permission (#2ebg32y)
|
@dixitdeepak test notification |
… upon server permission (#2ebg32y)
…ission (#2ebg32y)
…sume (#2ebg32y) Upgraded the casl library to latest version
…bg32y) Improved the data model for user, store permissions directly in user state instead of profile in order to reduce its dependency
Improved services to provision token Moved code to get profile to login When the user login into the application, data like productstore, shopify config, timezone are required for proper functioning of application. If either of them fails, we could have uncertain behaviour from the application
…g32y) Additional change: Refactored code, removed some methods and moved code to callee method
…actions based upon permissions (#2ebg32y)
1. Used try/catch blocks to handle non 2xx error more effectively 2. Improved hasError method to handle cases for error returned as string in some cases 3. Added missing translations
adityasharma7
changed the title
adityasharma7
changed the title
adityasharma7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
With the new authorization feature, app-level access permissions could be defined. Server permissions are being processed with certain rules and app-level permissions are identified. With specific app permission, users could perform specific actions.
Closes #360
https://app.clickup.com/t/2ebg32y
Short Description and Why It's Useful
Authorization is one of the key features of any DXP. The app should be able to identify the access permission of the user and allow/disallow the user with access accordingly.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance