Implemented: code to add functionality to subscribe or unsubscribe a webhook(#2ftb11u) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logic on products view job manager app
…vices for subscription and unsubscription
…gle does'nt switch back to previous state
…tate type to any(#2ftb11u)
… of webhook(#2ftb11u)
…ding action mapping and then using the same when calling the action(#2ftb11u)
…efined a mapping having id and correspoding service(#2ftb11u)
…instead of data property or methods(#2ftb11u)
…e to unsubscribeWebhook and added error handling in the unsubscribe action logic(#2ftb11u)
adityasharma7
suggested changes
Jun 17, 2022
| @@ -0,0 +1,7 @@ | |||
| export default interface WebhookState { | |||
| cached: any | |||
| key: { | |||
There was a problem hiding this comment.
We could remove this
There was a problem hiding this comment.
Sir, removed unwanted state
src/views/InitialLoad.vue
Outdated
| }), | ||
| fileStatusUpdateWebhook(): boolean { | ||
| const webhookTopic = this.webhookEnums['BULK_OPERATIONS_FINISH'] | ||
| return this.getCachedWebhook[webhookTopic]?.topic === webhookTopic |
There was a problem hiding this comment.
If we have topic as key, I think we could skip the comparison
…g service methods(#2ftb11u)
adityasharma7
suggested changes
Jun 17, 2022
src/store/modules/webhook/actions.ts
Outdated
| if (resp.status == 200 && resp.data.webhooks?.length > 0 && !hasError(resp)) { | ||
| const webhooks = resp.data.webhooks; | ||
| const topics: any = {} | ||
| webhooks.map((topic: any) => { |
There was a problem hiding this comment.
Suggested change
| webhooks.map((topic: any) => { | |
| webhooks.map((webhook: any) => { |
adityasharma7
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Dependent on #178
Closes #175
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance