Implemented: additional job actions, to job config component (#364tt29) #212
Conversation
src/components/JobConfiguration.vue
Outdated
| @@ -70,13 +70,34 @@ | |||
| <ion-button expand="block" @click="saveChanges()">{{ $t("Save changes") }}</ion-button> | |||
| </div> | |||
| </section> | |||
| <div class="job-actions"> | |||
| <ion-item slot="start" @click="viewJobHistory(currentJob)" button> | |||
There was a problem hiding this comment.
@azkyakhan Thoughts on slot here?
There was a problem hiding this comment.
This slots over here are not needed.
src/components/JobConfiguration.vue
Outdated
| <ion-item slot="end" @click="updatePinnedJobs(currentJob?.systemJobEnumId)" button> | ||
| <ion-icon slot="start" :icon="pinOutline" /> | ||
| {{ $t("Pin job") }} | ||
| <ion-checkbox :checked="getPinnedJobs.includes(currentJob.systemJobEnumId)" slot="end" /> |
There was a problem hiding this comment.
I am seeing slot in different places. Why not at the same place everytime?
src/components/JobConfiguration.vue
Outdated
| flex-basis: 50%; | ||
| } | ||
| .job-actions > ion-item > ion-checkbox{ | ||
| margin: unset; |
There was a problem hiding this comment.
Why do you need this? @azkyakhan
There was a problem hiding this comment.
Due to the margin on checkbox this item is looking like this :
That is why we have unset the margin on checkbox.
There was a problem hiding this comment.
I don't see problem here with checkbox spacing. Am I missing something?
There was a problem hiding this comment.
That item line is slight down from the adjacent item.
There was a problem hiding this comment.
Got it, what if we instead align content/items to end. I'd like to avoid changing item height from native behavior.
There was a problem hiding this comment.
Implemented align-items to end
src/components/JobConfiguration.vue
Outdated
| @@ -328,7 +416,19 @@ ion-list { | |||
|
|
|||
| .mobile-only { | |||
| display: none; | |||
| } | |||
| } | |||
| .job-actions { | |||
There was a problem hiding this comment.
We already have an "actions" class. So job actions doesn't make sense here I think. "More actions" seems better.
Implemented 'align-items: end' property instead of 'margin: unset'
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
additionalActionWorking.mp4
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance