Implemented: functionality to save 'auto cancel days' (#2cxr1cx) #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make a service (updateProductStore) and add a save button to the UI to save changes when user updates auto cancel days settings.
adityasharma7
suggested changes
Aug 5, 2022
| @@ -82,7 +82,10 @@ | |||
| </ion-card-header> | |||
| <ion-item> | |||
| <ion-label class="ion-text-wrap">{{ $t("Days") }}</ion-label> | |||
| <ion-input :placeholder="$t('before auto cancelation')" /> | |||
| <ion-input :placeholder="$t('before auto cancelation')" v-model.number="autoCancelDays" type="number" /> | |||
There was a problem hiding this comment.
I think we should also repopulate the already set value
…r handling (#2cxr1cx) used perform find to get the auto cancel days and added toast when auto cancel days are updated
ymaheshwari1
requested changes
Aug 5, 2022
adityasharma7
suggested changes
Aug 12, 2022
| @@ -424,6 +446,25 @@ export default defineComponent({ | |||
| } | |||
| }); | |||
| this.store.dispatch('webhook/fetchWebhooks') | |||
|
|
|||
| const payload = { | |||
There was a problem hiding this comment.
Implement a separate method to perform this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Make a service (updateProductStore) and add a save button to the UI to save changes when the user updates auto cancel days settings.
Screenshots of Visual Changes before/after (If There Are Any)
autoCancelDays.mp4
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance