Implemented: Miscellaneous page in job-manager(#364ttxy) #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Aug 10, 2022
…neous jobs(#364ttxy)
dt2patel
requested changes
Aug 10, 2022
dt2patel
requested changes
Aug 17, 2022
src/views/Miscellaneous.vue
Outdated
| </script> | ||
|
|
||
| <style scoped> | ||
| main > section { |
There was a problem hiding this comment.
indentation.
Also is this css not global? I don't think we need to re-add this for this page.
There was a problem hiding this comment.
Actually sir, that global css was getting applied but was not visible, then I discussed with Azkya ma'am and decided to override it with local css.
Fixed indetation.
adityasharma7
suggested changes
Aug 26, 2022
adityasharma7
suggested changes
Sep 2, 2022
src/views/Miscellaneous.vue
Outdated
| this.isJobDetailAnimationCompleted = true; | ||
| } | ||
| }, | ||
| async getMiscellaneousJobs(viewSize = 20, viewIndex = '0') { |
There was a problem hiding this comment.
I think we could have viewSize and viewIndex both numbers
src/store/modules/job/actions.ts
Outdated
| params.inputFields["productStoreId_op"] = "empty" | ||
| } | ||
|
|
||
| await JobService.fetchJobInformation(params).then((resp) => { |
There was a problem hiding this comment.
We could assign resp to a variable directly and use, instead of using await and then both
There was a problem hiding this comment.
Ok sir. Fixed it
ymaheshwari1
requested changes
Sep 2, 2022
ymaheshwari1
requested changes
Sep 2, 2022
ymaheshwari1
approved these changes
Sep 2, 2022
adityasharma7
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Screencast.from.Tuesday.09.August.2022.06.27.27.IST.webm
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance