Implemented: Add additional job actions to job config component(#364tt29) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented 'align-items: end' property instead of 'margin: unset'
dt2patel
requested changes
Aug 17, 2022
src/components/JobConfiguration.vue
Outdated
| row-gap: var(--spacer-sm); | ||
| margin-top: var(--spacer-sm); | ||
| } | ||
| .more-actions > ion-item { |
There was a problem hiding this comment.
we shouldn't specify ion item, it should just be all items in more-actions
There was a problem hiding this comment.
Made the requested change.
adityasharma7
suggested changes
Aug 26, 2022
src/components/JobConfiguration.vue
Outdated
| @@ -127,6 +155,9 @@ export default defineComponent({ | |||
| props: ["title", "status", "type"], | |||
| computed: { | |||
| ...mapGetters({ | |||
| getEnumDescription: 'job/getEnumDescription', | |||
| getEnumName: 'job/getEnumName', | |||
| getPinnedJobs: 'user/getPinnedJobs', | |||
There was a problem hiding this comment.
Suggested change
| getPinnedJobs: 'user/getPinnedJobs', | |
| pinnedJobs: 'user/getPinnedJobs', |
There was a problem hiding this comment.
Updated variable name.
src/components/JobConfiguration.vue
Outdated
| <ion-item @click="updatePinnedJobs(currentJob?.systemJobEnumId)" button> | ||
| <ion-icon slot="start" :icon="pinOutline" /> | ||
| {{ $t("Pin job") }} | ||
| <ion-checkbox slot="end" :checked="getPinnedJobs ? getPinnedJobs.includes(currentJob.systemJobEnumId) : false" /> |
There was a problem hiding this comment.
Suggested change
| <ion-checkbox slot="end" :checked="getPinnedJobs ? getPinnedJobs.includes(currentJob.systemJobEnumId) : false" /> | |
| <ion-checkbox slot="end" :checked="getPinnedJobs && getPinnedJobs.includes(currentJob.systemJobEnumId)" /> |
There was a problem hiding this comment.
Made the requested change.
|
@disha1202 Please add the image of the work you have done in this PR. |
Added the image. |
azkyakhan
approved these changes
Aug 26, 2022
|
LGTM |
1 similar comment
|
LGTM |
adityasharma7
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance