Added shopify config info at menu footer(#2q9mut9) #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Aug 17, 2022
src/components/Menu.vue
Outdated
| <ion-note slot="end">{{ userProfile?.userTimeZone }}</ion-note> | ||
| <div> | ||
| <ion-note slot="end">{{ userProfile?.userTimeZone }}</ion-note> | ||
| <ion-note slot="end">{{ currentShopifyConfigId }}</ion-note> |
There was a problem hiding this comment.
we should put this as a p tag below the ion label instead of putting it in the ion note
src/views/Settings.vue
Outdated
| @@ -18,7 +18,7 @@ | |||
| </ion-item> | |||
| <!-- Select shopify config --> | |||
| <ion-item> | |||
| <ion-icon :icon="globeOutline" slot="start" /> | |||
| <ion-icon :icon="pinOutline" slot="start" /> | |||
There was a problem hiding this comment.
Used basket outline icon
…ption is not available(#2q9mut9)
adityasharma7
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Additional change:
Fixed: Extra white space in job configuration component if job description is not available.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance