Fixed: error in console due to empty shopify configuration on logout(#2tky1f3) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Sep 9, 2022
src/components/Menu.vue
Outdated
| @@ -28,7 +28,7 @@ | |||
| <ion-label class="ion-text-wrap"> | |||
| <p class="overline">{{ instanceUrl }}</p> | |||
| {{ eComStore.storeName }} | |||
| <p>{{ currentShopifyConfig.name ? currentShopifyConfig.name : currentShopifyConfig.shopifyConfigName }}</p> | |||
| <p>{{ currentShopifyConfig?.name ? currentShopifyConfig.name : currentShopifyConfig?.shopifyConfigName }}</p> | |||
There was a problem hiding this comment.
WDYT?
Suggested change
| <p>{{ currentShopifyConfig?.name ? currentShopifyConfig.name : currentShopifyConfig?.shopifyConfigName }}</p> | |
| <p v-if="currentShopifyConfig">{{ currentShopifyConfig.name ? currentShopifyConfig.name : currentShopifyConfig.shopifyConfigName }}</p> |
There was a problem hiding this comment.
Set empty object by default to resolve this issue
adityasharma7
suggested changes
Sep 9, 2022
src/components/Menu.vue
Outdated
| @@ -28,7 +28,7 @@ | |||
| <ion-label class="ion-text-wrap"> | |||
| <p class="overline">{{ instanceUrl }}</p> | |||
| {{ eComStore.storeName }} | |||
| <p>{{ currentShopifyConfig.name ? currentShopifyConfig.name : currentShopifyConfig.shopifyConfigName }}</p> | |||
| <p>{{ currentShopifyConfig?.name ? currentShopifyConfig.name : currentShopifyConfig?.shopifyConfigName }}</p> | |||
There was a problem hiding this comment.
I think we should set it as empty object by default and this check will not be required then
There was a problem hiding this comment.
Set empty object by default to resolve this issue
…ponding to that product store(#2tky1f3)
adityasharma7
approved these changes
Sep 9, 2022
adityasharma7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance