Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add confirmation buttons to date pickers #256

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Feature: Add confirmation buttons to date pickers #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3554f3b
Adds show-default-buttons on BatchModal datepicker
franciscoemanuel Oct 29, 2022
11eabf0
Adds show-default-buttons on InitialJobConfiguration datepickers
franciscoemanuel Oct 29, 2022
936ff74
Adds show-default-buttons on JobConfiguration datepicker
franciscoemanuel Oct 29, 2022
7647a2f
Adds show-default-buttons on BulkEditor datepickers
franciscoemanuel Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/BatchModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</ion-radio-group>
<ion-item>
<ion-label position="fixed">{{ $t("Schedule") }}</ion-label>
<ion-datetime hour-cycle="h12" :value="currentBatch?.runTime ? getDateTime(currentBatch.runTime) : ''" @ionChange="updateRunTime($event)" presentation="time" size="cover" />
<ion-datetime show-default-buttons hour-cycle="h12" :value="currentBatch?.runTime ? getDateTime(currentBatch.runTime) : ''" @ionChange="updateRunTime($event)" presentation="time" size="cover" />
</ion-item>
<ion-fab @click="updateJob()" vertical="bottom" horizontal="end" slot="fixed">
<ion-fab-button>
Expand Down
4 changes: 3 additions & 1 deletion src/components/InitialJobConfiguration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<ion-modal :is-open="isOpen" @didDismiss="() => isOpen = false">
<ion-content force-overscroll="false">
<ion-datetime
show-default-buttons
hour-cycle="h12"
:min="minDateTime"
:value="currentJob?.runTime ? getDateTime(currentJob.runTime) : ''"
Expand Down Expand Up @@ -53,7 +54,8 @@
<ion-label @click="() => isOpen = true" slot="end">{{ currentJob?.runTime ? getTime(currentJob.runTime) : $t('Select run time') }}</ion-label>
<ion-modal class="date-time-modal" :is-open="isOpen" @didDismiss="() => isOpen = false">
<ion-content force-overscroll="false">
<ion-datetime
<ion-datetime
show-default-buttons
hour-cycle="h12"
:min="minDateTime"
:value="currentJob?.runTime ? getDateTime(currentJob?.runTime) : ''"
Expand Down
3 changes: 2 additions & 1 deletion src/components/JobConfiguration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<!-- <ion-button id="open-run-time-modal" size="small" fill="outline" color="medium" v-show="!currentJob?.runTime">{{ $t("Select run time") }}</ion-button> -->
<ion-modal class="date-time-modal" :is-open="isOpen" @didDismiss="() => isOpen = false">
<ion-content force-overscroll="false">
<ion-datetime
<ion-datetime
show-default-buttons
hour-cycle="h12"
:min="minDateTime"
:value="currentJob?.runTime ? getDateTime(currentJob.runTime) : ''"
Expand Down
6 changes: 4 additions & 2 deletions src/views/BulkEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
<ion-label class="ion-text-wrap" @click="() => isOpenGlobal = true" slot="end">{{ $t('Select run time') }}</ion-label>
<ion-modal class="date-time-modal" :is-open="isOpenGlobal" @didDismiss="() => isOpenGlobal = false">
<ion-content force-overscroll="false">
<ion-datetime
<ion-datetime
show-default-buttons
hour-cycle="h12"
/>
</ion-content>
Expand Down Expand Up @@ -118,7 +119,8 @@
<ion-label class="ion-text-wrap" @click="() => isOpen = true" slot="end">{{ $t('Select run time') }}</ion-label>
<ion-modal class="date-time-modal" :is-open="isOpen" @didDismiss="() => isOpen = false">
<ion-content force-overscroll="false">
<ion-datetime
<ion-datetime
show-default-buttons
hour-cycle="h12"
/>
</ion-content>
Expand Down