Implemented: predefined and custom option for selecting job run time (#85zrxc0xf) #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edefined (#85zrxc0xf)
ymaheshwari1
requested changes
Apr 24, 2023
src/components/JobConfiguration.vue
Outdated
| updateRunTime(event: CustomEvent) { | ||
| const value = event.detail.value | ||
| if (value != 'CUSTOM') { | ||
| // check for the first 5, predefined options |
There was a problem hiding this comment.
Update comment, why we have done this?
ymaheshwari1
approved these changes
Apr 25, 2023
adityasharma7
suggested changes
Apr 27, 2023
adityasharma7
suggested changes
May 2, 2023
src/components/JobConfiguration.vue
Outdated
| const value = event.detail.value | ||
| if (value != 'CUSTOM') { | ||
| // checking if a predefined option is selected i.e the first five options | ||
| const isPrefinedValue = this.runTimeOptions.slice(0, 5).some((option: any) => option.value === value) |
There was a problem hiding this comment.
Suggested change
| const isPrefinedValue = this.runTimeOptions.slice(0, 5).some((option: any) => option.value === value) | |
| const isPredefinedValue = this.runTimeOptions.slice(0, 5).some((option: any) => option.value === value) |
src/components/JobConfiguration.vue
Outdated
| }, | ||
| // value denotes the time in milliseconds for that label | ||
| runTimeOptions: () => [{ | ||
| "value": 0, |
There was a problem hiding this comment.
I think due to this time will be passed to server resulting in schedule failure
src/components/JobConfiguration.vue
Outdated
| value: setTime, | ||
| type: 'CUSTOM' | ||
| } | ||
| } else { |
There was a problem hiding this comment.
I think custom option will remain selected in this case
…improved code (#85zrxc0xf)
…time for all config components (#85zrxc0xf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #430
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Screencast.from.24-04-23.03.35.32.PM.IST.webm
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance