Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: changing the shopifyConfig now update the webhook(#700) #704

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#702

Short Description and Why It's Useful

  • Modify setCurrentShopifyConfig() to ensure that the shopifyConfig object includes the shopId and name
  • Update the fetchShopifyWebhooks service to handle cases where no webhook is subscribed for a specific shopifyConfig.

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/store/modules/user/actions.ts Outdated Show resolved Hide resolved
src/store/modules/webhook/actions.ts Outdated Show resolved Hide resolved
@R-Sourabh R-Sourabh requested a review from ymaheshwari1 April 29, 2024 04:50
@R-Sourabh R-Sourabh requested a review from ymaheshwari1 April 30, 2024 12:31
@ymaheshwari1 ymaheshwari1 merged commit 9a6caf5 into hotwax:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants