Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"demo" not allowed in instance name #88

Closed
dt2patel opened this issue Feb 17, 2024 · 1 comment · Fixed by #89
Closed

"demo" not allowed in instance name #88

dt2patel opened this issue Feb 17, 2024 · 1 comment · Fixed by #89
Assignees
@amansinghbais
Labels
bug Something isn't working

Comments

@dt2patel
Copy link
Contributor

Current behavior

We should make the instance chip red when instance is not found. There should be no scenario where user is not allowed to proceed to login page. Attached video where that is happening.

https://jam.dev/c/4545ecc6-f589-4dea-9942-1230ff81f293
@dt2patel dt2patel added the bug Something isn't working label Feb 17, 2024
@dt2patel dt2patel moved this to 📅 Planned in Digital Experience Platform Feb 17, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Feb 20, 2024
amansinghbais added a commit to amansinghbais/launchpad that referenced this issue Feb 20, 2024
@amansinghbais
Improved: added spinner in launchpad login next button to be shown wh…
d282c27 
…ile checkLoginOption request accomplishes (hotwax#88)
@amansinghbais amansinghbais mentioned this issue Feb 20, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/launchpad that referenced this issue Feb 20, 2024
@amansinghbais
Improved: added import for the IonSpinner in Login page (hotwax#88)
5417216
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 20, 2024
@dt2patel
Copy link
Contributor Author

Issue resolved by terminating dead instance under demo subdomain

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Feb 29, 2024
amansinghbais added a commit to amansinghbais/launchpad that referenced this issue Mar 20, 2024
@amansinghbais
Improved: variable name for checking whether api is loading or not (h…
bd54b83 
…otwax#88)
amansinghbais added a commit to amansinghbais/launchpad that referenced this issue Aug 23, 2024
@amansinghbais
Improved: code to stop click event over next button until api call in…
b56f8cd 
… progress (hotwax#88)
ymaheshwari1 added a commit that referenced this issue Aug 23, 2024
@ymaheshwari1
Merge pull request #89 from amansinghbais/88-demoLogin
a09e8ed 
Improved: added spinner in launchpad login next button to be shown while checkLoginOption request accomplishes (#88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amansinghbais amansinghbais

Labels
bug Something isn't working
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
2 participants
@dt2patel @amansinghbais