Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: OMS input reshowing on 'tab and enter' submit #75

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fixed: OMS input reshowing on 'tab and enter' submit #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/views/Login.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@
<section v-if="showOmsInput">
<ion-item lines="full">
<ion-label position="fixed">{{ $t("OMS") }}</ion-label>
<ion-input name="instanceUrl" v-model="instanceUrl" id="instanceUrl" type="text" required />
<ion-input name="instanceUrl" v-model="instanceUrl" id="instanceUrl" type="text" required />
</ion-item>

<div class="ion-padding">
<ion-button color="primary" expand="block" @click="setOms()">
<!-- @keyup.enter.stop to stop the form from submitting on enter press as keyup.enter is already bound
through the form above, causing both the form and the button to submit. -->
<ion-button color="primary" expand="block" @click.prevent="setOms()" @keyup.enter.stop>
{{ $t("Next") }}
<ion-icon slot="end" :icon="arrowForwardOutline" />
</ion-button>
Expand Down Expand Up @@ -224,7 +226,7 @@
this.loginOption = resp.data
}
} catch (error) {
console.error(error)

Check warning on line 229 in src/views/Login.vue

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (16.x) 

Unexpected console statement
}
},
async login() {
Expand All @@ -245,7 +247,7 @@
this.router.push('/')
}
} catch (error) {
console.error(error)

Check warning on line 250 in src/views/Login.vue

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (16.x) 

Unexpected console statement
}
},
async samlLogin() {
Expand All @@ -258,7 +260,7 @@
this.router.push('/')
}
} catch (error) {
console.error(error)

Check warning on line 263 in src/views/Login.vue

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (16.x) 

Unexpected console statement
}
},
async confirmActvSessnLoginOnRedrct() {
Expand Down
Loading