Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: product identifier component in settings page from dxp-components (dxp-178) #175

Merged

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Oct 12, 2023

Related Issues

Related Issue: hotwax/dxp-components#178
closes #150

Short Description and Why It's Useful

  • Improved the code to use the product identifier component implemented in dxp-components on the settings page.
  • Removed services and action for setting and getting ProductIdentificationPref.

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@ravilodhi ravilodhi merged commit 4765be1 into hotwax:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Product Identifier
2 participants