Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for dynamic features #166

Closed
dt2patel opened this issue Jun 30, 2023 · 1 comment
Closed

Support for dynamic features #166

dt2patel opened this issue Jun 30, 2023 · 1 comment
Assignees
@amansinghbais
Labels
enhancement New feature or request

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

If a product doesn't have exact "Color" and "Size" feature attributes, the variant selector doesn't work. Users have no way to switch between products then.

What are the acceptance criteria?

Features should be dynamically rendered and not dependent on exact feature type.
@dt2patel dt2patel added the bug Something isn't working label Jun 30, 2023
@dt2patel dt2patel self-assigned this Jun 30, 2023
@dt2patel dt2patel assigned adityasharma7 and unassigned dt2patel Jun 30, 2023
@dt2patel dt2patel moved this to 📋 Backlog in Digital Experience Platform Jun 30, 2023
@alsoK2maan alsoK2maan moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Aug 23, 2023
@alsoK2maan alsoK2maan moved this from 🏗 In progress to 📋 Backlog in Digital Experience Platform Aug 23, 2023
@Dhiraj1405 Dhiraj1405 added bug Something isn't working and removed bug Something isn't working labels Sep 1, 2023
@amansinghbais amansinghbais moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Sep 1, 2023
@amansinghbais amansinghbais moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Sep 1, 2023
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Sep 7, 2023
@amansinghbais
Implemented: support for dynamic features for product variants in pro…
7eea48b 
…duct summary page (hotwax#166)
@amansinghbais amansinghbais mentioned this issue Sep 7, 2023
Closed
1 task
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Sep 7, 2023
@amansinghbais
Merge branch 'main' of https://github.com/amansinghbais/preorder into…
5e8879d 
… preorder/hotwax#166
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Sep 7, 2023
@amansinghbais
Fixed: added missing comma in catalog-product-details page (hotwax#166)
ddb5e14
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Sep 7, 2023
@Dhiraj1405 Dhiraj1405 added enhancement New feature or request and removed bug Something isn't working labels Oct 11, 2023
@amansinghbais amansinghbais moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Oct 12, 2023
@amansinghbais amansinghbais moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Oct 16, 2023
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Oct 18, 2023
@amansinghbais amansinghbais moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Oct 18, 2023
@amansinghbais amansinghbais moved this from 📅 Planned to 📋 Backlog in Digital Experience Platform Oct 20, 2023
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Oct 23, 2023
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Oct 25, 2023
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/preorder into preorder/
26385e5 
hotwax#166
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Oct 25, 2023
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/preorder into preorder/
0fbd6ca 
hotwax#166
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Oct 25, 2023
@amansinghbais
Improved: code for making more optimal (hotwax#166)
67bea3d
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Oct 25, 2023
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to 📅 Planned in Digital Experience Platform Mar 28, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Apr 1, 2024
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Apr 2, 2024
@amansinghbais
Implemented: logic for dynamic support for product features (hotwax#166)
402b1c4
@amansinghbais amansinghbais mentioned this issue Apr 2, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Apr 3, 2024
@amansinghbais
Improved: removed unused parameters and code (hotwax#166)
a5d39ce
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Apr 3, 2024
@amansinghbais
Improved: simplified logic to update selected features (hotwax#166)
a48fde6
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Apr 3, 2024
@amansinghbais
Improved: logic for fetching features for the first time (hotwax#166)
691c635
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Apr 3, 2024
@amansinghbais
Improved: logic to update variantId in url on changing (hotwax#166)
51e11e8
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Apr 3, 2024
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to 🛑 On hold in Digital Experience Platform Jul 18, 2024
@amansinghbais amansinghbais moved this from 🛑 On hold to 📅 Planned in Digital Experience Platform Aug 30, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🛑 On hold in Digital Experience Platform Aug 30, 2024
@dt2patel dt2patel moved this from 🛑 On hold to 📅 Planned in Digital Experience Platform Oct 20, 2024
amansinghbais added a commit to amansinghbais/preorder that referenced this issue Nov 27, 2024
@amansinghbais
Improved: optmized the if-else condition on audit details page (hotwa…
dc5df8e 
…x#166)
ymaheshwari1 added a commit that referenced this issue Nov 27, 2024
@ymaheshwari1
Merge pull request #284 from amansinghbais/166-dynamic-features
3f999c2 
Implemented: logic for dynamic support for product features (#166)
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to ⏸️ Dev complete in Digital Experience Platform Nov 27, 2024
@dt2patel
Copy link
Contributor Author

dt2patel commented Feb 4, 2025

Checked on instances that don't have standard features and this is working fine Thanks

@dt2patel dt2patel closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amansinghbais amansinghbais

Labels
enhancement New feature or request
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
5 participants
@adityasharma7 @alsoK2maan @dt2patel @amansinghbais @Dhiraj1405