Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive shipment enhancement #402

Closed
3 tasks
ravilodhi opened this issue Oct 16, 2024 · 2 comments
Closed
3 tasks

Receive shipment enhancement #402

ravilodhi opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request release-v2.29.0

Comments

@ravilodhi
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently, the receive shipment functionality processes items one by one, making multiple requests equal to the number of items in the shipment. This approach is not scalable. Uploading a JSON of the items to be received and letting the backend logic handle the processing will make it more scalable.

What are the acceptance criteria?

Shipment items should be uploaded in a single API call and processed on the backend synchronously using the RECEIVE_SHIP_ITEMS data manager configuration. If any item fails, the shipment should not be marked as 'Received,' and the user should still be able to attempt receiving those items. No item should be successfully received more than once.

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

@ravilodhi ravilodhi self-assigned this Oct 16, 2024
@ravilodhi ravilodhi moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Oct 16, 2024
@ravilodhi ravilodhi moved this from 📅 Planned to ⏸️ Dev complete in Digital Experience Platform Oct 16, 2024
@ravilodhi ravilodhi moved this from ⏸️ Dev complete to 👀 In review in Digital Experience Platform Oct 16, 2024
ravilodhi added a commit that referenced this issue Oct 22, 2024
… items instead of doing multiple calls for creating/adding shipment and items. Also used the common flow for shipment, return and po to import the json file and processing the item receiving at backend. (#402)
@ravilodhi
Copy link
Contributor Author

This is dependant on OMS release 5.18.0.

ravilodhi added a commit that referenced this issue Nov 18, 2024
Improved: Receive shipment enhancement  (#402).
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Nov 18, 2024
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned ravilodhi Nov 27, 2024
@Adameddy26 Adameddy26 added enhancement New feature or request release-v2.29.0 labels Nov 27, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🔨 In QA in Digital Experience Platform Nov 27, 2024
@Adameddy26
Copy link

Verified and working fine in release v2.29.0. Hence, closing this issue.

@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-v2.29.0
Projects
Archived in project
Development

No branches or pull requests

2 participants