Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bridge registration #59

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fix bridge registration #59

merged 3 commits into from
Dec 16, 2024

Conversation

svara
Copy link
Contributor

@svara svara commented Dec 16, 2024

This PR fixes #57.

jayohms and others added 3 commits December 16, 2024 09:35
* main:
  Move the configuration of the custom user agent prefix to the AppDelegate.
  Swap order of parameters
  Fine tune custom user agent setting
  Set session's path config from the global path config.
  Consolidate all global config by moving it in app delegate.
  Add utility func to load path config to the Hotwire enum.
  Move `matchQueryStrings` to `PathConfiguration`.
  Move `registerBridgeComponents` to `AppDelegate`.
@svara svara requested a review from jayohms December 16, 2024 16:11
Copy link
Contributor

@jayohms jayohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@svara svara merged commit 21313e4 into main Dec 16, 2024
1 check passed
@svara svara deleted the fix-bridge-registration branch December 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hotwire.config.makeCustomWebView conflicts with Hotwire.registerBridgeComponents()
3 participants