Path config underscores #63
Merged
+15
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
svara
approved these changes
Dec 18, 2024
svara
reviewed
Dec 18, 2024
Comment on lines
+342
to
+351
| // For most view controllers, UIKit maps [automatic] to: | ||
| // UIModalPresentationStyle.formSheet in iOS 18 and later | ||
| // UIModalPresentationStyle.pageSheet in versions of iOS earlier than iOS 18 | ||
| // Some system view controllers may map it to a different style. | ||
| // https://developer.apple.com/documentation/uikit/uimodalpresentationstyle/automatic | ||
| if #available(iOS 18, *) { | ||
| XCTAssertEqual(modalNavigationController.modalPresentationStyle, .formSheet) | ||
| } else { | ||
| XCTAssertEqual(modalNavigationController.modalPresentationStyle, .pageSheet) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR matches path configuration values using underscores to match
Navigation.Presentation.clearAllandNavigation.Presentation.replaceRoot.It also removes an empty test file and fixes a test to work with iOS 18+.