Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support app/assets/builds out of the box? #11

Closed
excid3 opened this issue Dec 18, 2024 · 1 comment · Fixed by #13
Closed

Support app/assets/builds out of the box? #11

excid3 opened this issue Dec 18, 2024 · 1 comment · Fixed by #13

Comments

@excid3
Copy link
Contributor

excid3 commented Dec 18, 2024 •
edited
Loading

With cssbundling-rails or tailwindcss-rails, the app/assets/builds folder is the main place to watch for CSS files.

Would it make sense to include this folder in the engine's default config? Happy to make a PR if so!

https://github.com/basecamp/hotwire-spark/blob/c8ce327654dc370ce8c217d984e59d6614bad1c0/lib/hotwire/spark/engine.rb#L11

      css_paths: %w[ app/assets/stylesheets app/assets/builds ],
@jorgemanrubia
Copy link
Member

Yes @excid3 thanks, go for it!

We're interested in supporting jsbundling and cssbundling out of the box, even if we didn't target those in the initial version.

excid3 added a commit to excid3/hotwire-spark that referenced this issue Dec 18, 2024
@excid3
Add builds folder for CSS monitoring
cc6849e 
Closes hotwired#11
@excid3 excid3 mentioned this issue Dec 18, 2024
Merged
@jorgemanrubia jorgemanrubia mentioned this issue Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add builds folder for monitoring excid3/hotwire-spark
2 participants
@excid3 @jorgemanrubia